Skip to content

Commit 2f72014

Browse files
dayshahedoakes
andauthored
[core] Skip storage test on win (#51286)
The test is consistently failing on windows because ray is failing to start up with the specified storage path. We are deprecating this storage API anyways, so we can skip this on windows. Closes #48922 Signed-off-by: dayshah <dhyey2019@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
1 parent 572f676 commit 2f72014

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

python/ray/tests/test_storage.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# -*- coding: utf-8 -*-
22

33
import os
4+
import sys
45
import subprocess
56
import urllib
67
from pathlib import Path
@@ -141,6 +142,9 @@ def test_get_filesystem_invalid(shutdown_only, tmp_path):
141142
ray.init(storage="blahblah://bad")
142143

143144

145+
@pytest.mark.skipif(
146+
sys.platform == "win32", reason="Fails on Windows + Deprecating storage"
147+
)
144148
def test_get_filesystem_remote_workers(shutdown_only, tmp_path):
145149
path = os.path.join(str(tmp_path), "foo/bar")
146150
ray.init(storage=path, num_gpus=1)

0 commit comments

Comments
 (0)