Skip to content

Commit 10363e7

Browse files
koriymclaude
andcommitted
Fix doc-block parameter order and add InjectionPoint serialization test
- Fix @param tag order in ContainerFactory to match method signature - Add serialization test for InjectionPoint to improve test coverage - Enhance static analysis accuracy and IDE support 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent a08a24f commit 10363e7

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

src/di/ContainerFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
final class ContainerFactory
1515
{
1616
/**
17-
* @param non-empty-string $classDir
1817
* @param AbstractModule|ModuleList|null $module Module(s)
18+
* @param non-empty-string $classDir
1919
*/
2020
public function __invoke($module, string $classDir): Container
2121
{

tests/di/InjectionPointTest.php

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77
use PHPUnit\Framework\TestCase;
88
use ReflectionParameter;
99

10+
use function assert;
11+
use function serialize;
12+
use function unserialize;
13+
1014
class InjectionPointTest extends TestCase
1115
{
1216
/** @var InjectionPointInterface */
@@ -45,4 +49,15 @@ public function testGetQualifiers(): void
4549
$this->assertCount(1, $annotations);
4650
$this->assertInstanceOf(FakeConstant::class, $annotations[0]);
4751
}
52+
53+
public function testSerialize(): void
54+
{
55+
$serialized = serialize($this->ip);
56+
$unserialized = unserialize($serialized);
57+
assert($unserialized instanceof InjectionPoint);
58+
59+
$this->assertEquals($this->parameter->name, $unserialized->getParameter()->name);
60+
$this->assertEquals($this->parameter->getDeclaringFunction()->name, $unserialized->getParameter()->getDeclaringFunction()->name);
61+
$this->assertEquals($this->parameter->getDeclaringClass()->name, $unserialized->getParameter()->getDeclaringClass()->name);
62+
}
4863
}

0 commit comments

Comments
 (0)