Merge remote-tracking branch 'origin/hash-key-generator' into hash-key-generator

Author: rawilk

src/Contracts/ContextSerializer.php

@@ -8,5 +8,5 @@
 
 interface ContextSerializer
 {
-    public function serialize(Context $context = null): string;
+    public function serialize(?Context $context = null): string;
 }

src/Contracts/KeyGenerator.php

@@ -8,7 +8,7 @@
 
 interface KeyGenerator
 {
-    public function generate(string $key, Context $context = null): string;
+    public function generate(string $key, ?Context $context = null): string;
 
     public function removeContextFromKey(string $key): string;
 

src/Drivers/DatabaseDriver.php

@@ -17,8 +17,7 @@ public function __construct(
         protected Connection $connection,
         protected string $table,
         protected ?string $teamForeignKey = null,
-    ) {
-    }
+    ) {}
 
     public function forget($key, $teamId = null): void
     {

src/Drivers/EloquentDriver.php

@@ -10,9 +10,7 @@
 
 class EloquentDriver implements Driver
 {
-    public function __construct(protected Setting $model)
-    {
-    }
+    public function __construct(protected Setting $model) {}
 
     public function forget($key, $teamId = null): void
     {

src/Drivers/Factory.php

@@ -17,11 +17,9 @@ class Factory
 
     protected array $customCreators = [];
 
-    public function __construct(protected Application $app)
-    {
-    }
+    public function __construct(protected Application $app) {}
 
-    public function driver(string $driver = null): Driver
+    public function driver(?string $driver = null): Driver
     {
         return $this->resolveDriver($driver);
     }
@@ -64,7 +62,7 @@ protected function getDriverConfig(string $driver): ?array
         return $this->app['config']["settings.drivers.{$driver}"];
     }
 
-    protected function resolveDriver(string $driver = null): Driver
+    protected function resolveDriver(?string $driver = null): Driver
     {
         $driver = $driver ?: $this->getDefaultDriver();
 

src/Events/SettingWasDeleted.php

@@ -19,6 +19,5 @@ public function __construct(
         public string $cacheKey,
         public mixed $teamId,
         public bool|Context|null $context,
-    ) {
-    }
+    ) {}
 }

src/Events/SettingWasStored.php

@@ -20,6 +20,5 @@ public function __construct(
         public mixed $value,
         public mixed $teamId,
         public bool|Context|null $context,
-    ) {
-    }
+    ) {}
 }

src/Events/SettingsFlushed.php

@@ -18,6 +18,5 @@ public function __construct(
         public bool|Collection|string $keys,
         public mixed $teamId,
         public bool|Context|null $context,
-    ) {
-    }
+    ) {}
 }

src/Settings.php

@@ -66,8 +66,7 @@ public function __construct(
         protected Driver $driver,
         protected KeyGenerator $keyGenerator,
         protected ValueSerializer $valueSerializer,
-    ) {
-    }
+    ) {}
 
     // mainly for testing purposes
     public function getDriver(): Driver
@@ -79,7 +78,7 @@ public function getDriver(): Driver
      * Pass in `false` for context when calling `all()` to only return results
      * that do not have context.
      */
-    public function context(Context|bool $context = null): self
+    public function context(Context|bool|null $context = null): self
     {
         $this->context = $context;
 

src/Support/ContextSerializers/ContextSerializer.php

@@ -9,7 +9,7 @@
 
 class ContextSerializer implements ContextSerializerContract
 {
-    public function serialize(Context $context = null): string
+    public function serialize(?Context $context = null): string
     {
         return serialize($context);
     }

src/Support/ContextSerializers/DotNotationContextSerializer.php

@@ -9,7 +9,7 @@
 
 class DotNotationContextSerializer implements ContextSerializerContract
 {
-    public function serialize(Context $context = null): string
+    public function serialize(?Context $context = null): string
     {
         if (is_null($context)) {
             return '';

src/Support/KeyGenerators/HashKeyGenerator.php

@@ -13,7 +13,7 @@ class HashKeyGenerator implements KeyGeneratorContract
 {
     protected ContextSerializer $serializer;
 
-    public function generate(string $key, Context $context = null): string
+    public function generate(string $key, ?Context $context = null): string
     {
         return hash(
             config('settings.hash_algorithm', 'xxh128'),

src/Support/KeyGenerators/Md5KeyGenerator.php

@@ -13,7 +13,7 @@ class Md5KeyGenerator implements KeyGeneratorContract
 {
     protected ContextSerializer $serializer;
 
-    public function generate(string $key, Context $context = null): string
+    public function generate(string $key, ?Context $context = null): string
     {
         return md5($key . $this->serializer->serialize($context));
     }

src/Support/KeyGenerators/ReadableKeyGenerator.php

@@ -13,7 +13,7 @@ class ReadableKeyGenerator implements KeyGeneratorContract
 {
     protected ContextSerializer $serializer;
 
-    public function generate(string $key, Context $context = null): string
+    public function generate(string $key, ?Context $context = null): string
     {
         $key = $this->normalizeKey($key);
 

tests/Support/Drivers/CustomDriver.php

@@ -34,7 +34,5 @@ public function all($teamId = null, $keys = null): array|Arrayable
         return [];
     }
 
-    public function flush($teamId = null, $keys = null): void
-    {
-    }
+    public function flush($teamId = null, $keys = null): void {}
 }