Skip to content

Commit 861e25f

Browse files
pelwellpopcornmix
authored andcommitted
arm64: dts: Clean up the downstream patches
Remove some gratuitous differences with the upstream dts, and drop the unnecessary 'status = "okay"' properties (they are needed(*) to override 'status = "disabled"' in the original definitions. (*) You could technically delete the original properties, but that looks worse and doesn't work in an overlay. Signed-off-by: Phil Elwell <phil@raspberrypi.com>
1 parent 824492e commit 861e25f

File tree

3 files changed

+25
-39
lines changed

3 files changed

+25
-39
lines changed

arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts

Lines changed: 13 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// SPDX-License-Identifier: GPL-2.0
1+
// SPDX-License-Identifier: (GPL-2.0 OR MIT)
22
/dts-v1/;
33

44
#include <dt-bindings/gpio/gpio.h>
@@ -42,7 +42,7 @@
4242
};
4343
};
4444

45-
sd_io_1v8_reg: sd_io_1v8_reg {
45+
sd_io_1v8_reg: sd-io-1v8-reg {
4646
compatible = "regulator-gpio";
4747
regulator-name = "vdd-sd-io";
4848
regulator-min-microvolt = <1800000>;
@@ -51,23 +51,21 @@
5151
regulator-always-on;
5252
regulator-settling-time-us = <5000>;
5353
gpios = <&gio_aon 3 GPIO_ACTIVE_HIGH>;
54-
states = <1800000 0x1
55-
3300000 0x0>;
56-
status = "okay";
54+
states = <1800000 1>,
55+
<3300000 0>;
5756
};
5857

59-
sd_vcc_reg: sd_vcc_reg {
58+
sd_vcc_reg: sd-vcc-reg {
6059
compatible = "regulator-fixed";
6160
regulator-name = "vcc-sd";
6261
regulator-min-microvolt = <3300000>;
6362
regulator-max-microvolt = <3300000>;
6463
regulator-boot-on;
6564
enable-active-high;
6665
gpios = <&gio_aon 4 GPIO_ACTIVE_HIGH>;
67-
status = "okay";
6866
};
6967

70-
wl_on_reg: wl_on_reg {
68+
wl_on_reg: wl-on-reg {
7169
compatible = "regulator-fixed";
7270
regulator-name = "wl-on-regulator";
7371
regulator-min-microvolt = <3300000>;
@@ -97,22 +95,19 @@
9795
compatible = "regulator-fixed";
9896
regulator-name = "cam0_reg";
9997
enable-active-high;
100-
status = "okay";
10198
gpio = <&rp1_gpio 34 0>; // CD0_IO0_MICCLK, to MIPI 0 connector
10299
};
103100

104101
cam1_reg: cam1_reg {
105102
compatible = "regulator-fixed";
106103
regulator-name = "cam1_reg";
107104
enable-active-high;
108-
status = "okay";
109105
gpio = <&rp1_gpio 46 0>; // CD1_IO0_MICCLK, to MIPI 1 connector
110106
};
111107

112108
cam_dummy_reg: cam_dummy_reg {
113109
compatible = "regulator-fixed";
114110
regulator-name = "cam-dummy-reg";
115-
status = "okay";
116111
};
117112

118113
dummy: dummy {
@@ -131,11 +126,6 @@ rp1_target: &pcie2 {
131126
status = "okay";
132127
};
133128

134-
// Add some labels to 2712 device
135-
136-
// The system UART
137-
&uart10 { status = "okay"; };
138-
139129
// The system SPI for the bootloader EEPROM
140130
&spi10 { status = "okay"; };
141131

@@ -188,6 +178,13 @@ rp1_target: &pcie2 {
188178
};
189179
};
190180

181+
/* The Debug UART, on Rpi5 it's on JST-SH 1.0mm 3-pin connector
182+
* labeled "UART", i.e. the interface with the system console.
183+
*/
184+
&uart10 {
185+
status = "okay";
186+
};
187+
191188
gpio: &rp1_gpio {
192189
status = "okay";
193190
};
@@ -716,10 +713,6 @@ spi10_cs_pins: &spi10_cs_gpio1 {};
716713
clock-names = "hdmi", "bvb", "audio", "cec";
717714
};
718715

719-
&pcie1 {
720-
status = "okay";
721-
};
722-
723716
&pcie2 {
724717
status = "okay";
725718
};

arch/arm64/boot/dts/broadcom/bcm2712-rpi-cm5.dtsi

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// SPDX-License-Identifier: GPL-2.0
1+
// SPDX-License-Identifier: (GPL-2.0 OR MIT)
22

33
#include <dt-bindings/gpio/gpio.h>
44
#include <dt-bindings/clock/rp1.h>
@@ -41,26 +41,25 @@
4141
};
4242
};
4343

44-
sd_io_1v8_reg: sd_io_1v8_reg {
44+
sd_io_1v8_reg: sd-io-1v8-reg {
4545
compatible = "regulator-fixed";
4646
regulator-name = "vdd-sd-io";
4747
regulator-min-microvolt = <1800000>;
4848
regulator-max-microvolt = <1800000>;
4949
regulator-always-on;
5050
};
5151

52-
sd_vcc_reg: sd_vcc_reg {
52+
sd_vcc_reg: sd-vcc-reg {
5353
compatible = "regulator-fixed";
5454
regulator-name = "vcc-sd";
5555
regulator-min-microvolt = <3300000>;
5656
regulator-max-microvolt = <3300000>;
5757
regulator-boot-on;
5858
enable-active-high;
5959
gpios = <&gio_aon 4 GPIO_ACTIVE_HIGH>;
60-
status = "okay";
6160
};
6261

63-
wl_on_reg: wl_on_reg {
62+
wl_on_reg: wl-on-reg {
6463
compatible = "regulator-fixed";
6564
regulator-name = "wl-on-regulator";
6665
regulator-min-microvolt = <3300000>;
@@ -90,14 +89,12 @@
9089
compatible = "regulator-fixed";
9190
regulator-name = "cam0_reg";
9291
enable-active-high;
93-
status = "okay";
94-
gpio = <&rp1_gpio 34 0>; // CD0_IO0_MICCLK, to CAM_GPIO on connector
92+
gpio = <&rp1_gpio 34 0>; // CD0_IO0_MICCLK, to CAM_GPIO on connector
9593
};
9694

9795
cam_dummy_reg: cam_dummy_reg {
9896
compatible = "regulator-fixed";
9997
regulator-name = "cam-dummy-reg";
100-
status = "okay";
10198
};
10299

103100
dummy: dummy {
@@ -116,11 +113,6 @@ rp1_target: &pcie2 {
116113
status = "okay";
117114
};
118115

119-
// Add some labels to 2712 device
120-
121-
// The system UART
122-
&uart10 { status = "okay"; };
123-
124116
// The system SPI for the bootloader EEPROM
125117
&spi10 { status = "okay"; };
126118

@@ -175,6 +167,13 @@ rp1_target: &pcie2 {
175167
};
176168
};
177169

170+
/* The Debug UART, on Rpi5 it's on JST-SH 1.0mm 3-pin connector
171+
* labeled "UART", i.e. the interface with the system console.
172+
*/
173+
&uart10 {
174+
status = "okay";
175+
};
176+
178177
gpio: &rp1_gpio {
179178
status = "okay";
180179
};

arch/arm64/boot/dts/broadcom/bcm2712-rpi.dtsi

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,11 @@
3535
fb: fb {
3636
compatible = "brcm,bcm2708-fb";
3737
firmware = <&firmware>;
38-
status = "okay";
3938
};
4039

4140
rpi_rtc: rpi_rtc {
4241
compatible = "raspberrypi,rpi-rtc";
4342
firmware = <&firmware>;
44-
status = "okay";
4543
trickle-charge-microvolt = <0>;
4644
};
4745

@@ -54,28 +52,24 @@
5452
compatible = "raspberrypi,rpi-otp";
5553
firmware = <&firmware>;
5654
reg = <0 192>;
57-
status = "okay";
5855
};
5956

6057
nvmem_cust: nvmem_cust {
6158
compatible = "raspberrypi,rpi-otp";
6259
firmware = <&firmware>;
6360
reg = <1 8>;
64-
status = "okay";
6561
};
6662

6763
nvmem_mac: nvmem_mac {
6864
compatible = "raspberrypi,rpi-otp";
6965
firmware = <&firmware>;
7066
reg = <2 6>;
71-
status = "okay";
7267
};
7368

7469
nvmem_priv: nvmem_priv {
7570
compatible = "raspberrypi,rpi-otp";
7671
firmware = <&firmware>;
7772
reg = <3 16>;
78-
status = "okay";
7973
};
8074
};
8175

0 commit comments

Comments
 (0)