Skip to content

Commit 5e8ff13

Browse files
mripardpopcornmix
authored andcommitted
drm/vc4: tests: Drop drm parameter for vc4_find_crtc_for_encoder
The DRM device pointer and the DRM encoder pointer are redundant, since the latter is attached to the former and we can just follow the drm_encoder->dev pointer. Let's remove the drm_device pointer argument. Signed-off-by: Maxime Ripard <maxime@cerno.tech>
1 parent 6836985 commit 5e8ff13

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

drivers/gpu/drm/vc4/tests/vc4_mock.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77

88
static inline
99
struct drm_crtc *vc4_find_crtc_for_encoder(struct kunit *test,
10-
struct drm_device *drm,
1110
struct drm_encoder *encoder)
1211
{
12+
struct drm_device *drm = encoder->dev;
1313
struct drm_crtc *crtc;
1414

1515
KUNIT_ASSERT_EQ(test, hweight32(encoder->possible_crtcs), 1);

drivers/gpu/drm/vc4/tests/vc4_mock_output.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ int vc4_mock_atomic_add_output(struct kunit *test,
7777
encoder = vc4_find_encoder_by_type(drm, type);
7878
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, encoder);
7979

80-
crtc = vc4_find_crtc_for_encoder(test, drm, encoder);
80+
crtc = vc4_find_crtc_for_encoder(test, encoder);
8181
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, crtc);
8282

8383
output = encoder_to_vc4_dummy_output(encoder);
@@ -115,7 +115,7 @@ int vc4_mock_atomic_del_output(struct kunit *test,
115115
encoder = vc4_find_encoder_by_type(drm, type);
116116
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, encoder);
117117

118-
crtc = vc4_find_crtc_for_encoder(test, drm, encoder);
118+
crtc = vc4_find_crtc_for_encoder(test, encoder);
119119
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, crtc);
120120

121121
crtc_state = drm_atomic_get_crtc_state(state, crtc);

drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ get_vc4_crtc_state_for_encoder(struct kunit *test,
131131
encoder = vc4_find_encoder_by_type(drm, type);
132132
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, encoder);
133133

134-
crtc = vc4_find_crtc_for_encoder(test, drm, encoder);
134+
crtc = vc4_find_crtc_for_encoder(test, encoder);
135135
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, crtc);
136136

137137
new_crtc_state = drm_atomic_get_new_crtc_state(state, crtc);

0 commit comments

Comments
 (0)