Skip to content

Commit 5452f24

Browse files
pelwellpopcornmix
authored andcommitted
Revert "PCI: brcmstb: don't use ASPM state defines for register bits"
This reverts commit 13a0b47.
1 parent a3f749d commit 5452f24

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

drivers/pci/controller/pcie-brcmstb.c

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,6 @@
4747

4848
#define PCIE_RC_CFG_PRIV1_LINK_CAPABILITY 0x04dc
4949
#define PCIE_RC_CFG_PRIV1_LINK_CAPABILITY_ASPM_SUPPORT_MASK 0xc00
50-
#define PCIE_RC_CFG_PRIV1_LINK_CAPABILITY_ASPM_SUPPORT_L0S 0x1
51-
#define PCIE_RC_CFG_PRIV1_LINK_CAPABILITY_ASPM_SUPPORT_L1 0x2
52-
#define PCIE_RC_CFG_PRIV1_LINK_CAPABILITY_MAX_LINK_SPEED_MASK 0xf
5350

5451
#define PCIE_RC_CFG_PRIV1_ROOT_CAP 0x4f8
5552
#define PCIE_RC_CFG_PRIV1_ROOT_CAP_L1SS_MODE_MASK 0xf8
@@ -1336,11 +1333,10 @@ static int brcm_pcie_setup(struct brcm_pcie *pcie)
13361333
pcie->msi_target_addr = BRCM_MSI_TARGET_ADDR_GT_4GB;
13371334

13381335

1339-
/* Always advertise L1 capability */
1340-
aspm_support = PCIE_RC_CFG_PRIV1_LINK_CAPABILITY_ASPM_SUPPORT_L1;
1341-
/* Advertise L0s capability unless 'aspm-no-l0s' is set */
1336+
/* Don't advertise L0s capability if 'aspm-no-l0s' */
1337+
aspm_support = PCIE_LINK_STATE_L1;
13421338
if (!of_property_read_bool(pcie->np, "aspm-no-l0s"))
1343-
aspm_support |= PCIE_RC_CFG_PRIV1_LINK_CAPABILITY_ASPM_SUPPORT_L0S;
1339+
aspm_support |= PCIE_LINK_STATE_L0S;
13441340
tmp = readl(base + PCIE_RC_CFG_PRIV1_LINK_CAPABILITY);
13451341
u32p_replace_bits(&tmp, aspm_support,
13461342
PCIE_RC_CFG_PRIV1_LINK_CAPABILITY_ASPM_SUPPORT_MASK);

0 commit comments

Comments
 (0)