Skip to content

Commit 4ea0883

Browse files
Dragan Simicgregkh
authored andcommitted
arm64: dts: rockchip: Add avdd HDMI supplies to RockPro64 board dtsi
[ Upstream commit bd1c959 ] Add missing "avdd-0v9-supply" and "avdd-1v8-supply" properties to the "hdmi" node in the Pine64 RockPro64 board dtsi file. To achieve this, also add the associated "vcca_0v9" regulator that produces the 0.9 V supply, [1][2] which hasn't been defined previously in the board dtsi file. This also eliminates the following warnings from the kernel log: dwhdmi-rockchip ff940000.hdmi: supply avdd-0v9 not found, using dummy regulator dwhdmi-rockchip ff940000.hdmi: supply avdd-1v8 not found, using dummy regulator There are no functional changes to the way board works with these additions, because the "vcc1v8_dvp" and "vcca_0v9" regulators are always enabled, [1][2] but these additions improve the accuracy of hardware description. These changes apply to the both supported hardware revisions of the Pine64 RockPro64, i.e. to the production-run revisions 2.0 and 2.1. [1][2] [1] https://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf [2] https://files.pine64.org/doc/rockpro64/rockpro64_v20-SCH.pdf Fixes: e4f3fb4 ("arm64: dts: rockchip: add initial dts support for Rockpro64") Cc: stable@vger.kernel.org Suggested-by: Diederik de Haas <didi.debian@cknow.org> Signed-off-by: Dragan Simic <dsimic@manjaro.org> Tested-by: Diederik de Haas <didi.debian@cknow.org> Link: https://lore.kernel.org/r/df3d7e8fe74ed5e727e085b18c395260537bb5ac.1740941097.git.dsimic@manjaro.org Signed-off-by: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 1fc00e1 commit 4ea0883

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,16 @@
227227
vin-supply = <&vcc12v_dcin>;
228228
};
229229

230+
vcca_0v9: vcca-0v9 {
231+
compatible = "regulator-fixed";
232+
regulator-name = "vcca_0v9";
233+
regulator-always-on;
234+
regulator-boot-on;
235+
regulator-min-microvolt = <900000>;
236+
regulator-max-microvolt = <900000>;
237+
vin-supply = <&vcc3v3_sys>;
238+
};
239+
230240
vdd_log: vdd-log {
231241
compatible = "pwm-regulator";
232242
pwms = <&pwm2 0 25000 1>;
@@ -312,6 +322,8 @@
312322
};
313323

314324
&hdmi {
325+
avdd-0v9-supply = <&vcca_0v9>;
326+
avdd-1v8-supply = <&vcc1v8_dvp>;
315327
ddc-i2c-bus = <&i2c3>;
316328
pinctrl-names = "default";
317329
pinctrl-0 = <&hdmi_cec>;

0 commit comments

Comments
 (0)