Skip to content

Commit 2dd2f36

Browse files
dereference23pelwell
authored andcommitted
vc04_services/vc-sm-cma: Switch one-bit bitfields to bool
Clang 16 warns: ../drivers/staging/vc04_services/vc-sm-cma/vc_sm.c:816:19: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion] buffer->imported = 1; ^ ~ ../drivers/staging/vc04_services/vc-sm-cma/vc_sm.c:822:17: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion] buffer->in_use = 1; ^ ~ 2 warnings generated. Signed-off-by: Alexander Winkowski <dereference23@outlook.com>
1 parent ec61075 commit 2dd2f36

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

drivers/staging/vc04_services/vc-sm-cma/vc_sm.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@ static void vc_sm_dma_buf_release(struct dma_buf *dmabuf)
533533

534534
pr_debug("%s dmabuf %p, buffer %p\n", __func__, dmabuf, buffer);
535535

536-
buffer->in_use = 0;
536+
buffer->in_use = false;
537537

538538
/* Unmap on the VPU */
539539
vc_sm_vpu_free(buffer);
@@ -813,13 +813,13 @@ vc_sm_cma_import_dmabuf_internal(struct vc_sm_privdata_t *private,
813813
buffer->size = import.size;
814814
buffer->vpu_state = VPU_MAPPED;
815815

816-
buffer->imported = 1;
816+
buffer->imported = true;
817817
buffer->import.dma_buf = dma_buf;
818818

819819
buffer->import.attach = attach;
820820
buffer->import.sgt = sgt;
821821
buffer->dma_addr = dma_addr;
822-
buffer->in_use = 1;
822+
buffer->in_use = true;
823823
buffer->kernel_id = import.kernel_id;
824824

825825
/*

drivers/staging/vc04_services/vc-sm-cma/vc_sm.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ struct vc_sm_buffer {
5757

5858
char name[VC_SM_MAX_NAME_LEN];
5959

60-
int in_use:1; /* Kernel is still using this resource */
61-
int imported:1; /* Imported dmabuf */
60+
bool in_use:1; /* Kernel is still using this resource */
61+
bool imported:1; /* Imported dmabuf */
6262

6363
enum vc_sm_vpu_mapping_state vpu_state;
6464
u32 vc_handle; /* VideoCore handle for this buffer */

0 commit comments

Comments
 (0)