PCI: brcmstb: Fix for missing of_node_put

Stanimir Varbanov · popcornmix · commit 2a8da85513f3 · 2025-03-18T14:32:21.000Z
A call to of_parse_phandle() increments refcount, of_node_put must be called when done the work on it. Fix missing of_node_put() on the msi_np device node by using scope based of_node_put() cleanups. Cc: stable@vger.kernel.org # v5.10+ Fixes: 40ca1bf ("PCI: brcmstb: Add MSI support") Signed-off-by: Stanimir Varbanov <svarbanov@suse.de>
diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
@@ -1844,7 +1844,8 @@ static struct pci_ops brcm7425_pcie_ops = {
 
 static int brcm_pcie_probe(struct platform_device *pdev)
 {
-	struct device_node *np = pdev->dev.of_node, *msi_np;
+	struct device_node *msi_np __free(device_node) = NULL;
+	struct device_node *np = pdev->dev.of_node;
 	struct pci_host_bridge *bridge;
 	const struct pcie_cfg_data *data;
 	struct brcm_pcie *pcie;

Original file line number	Diff line number	Diff line change
`@@ -1844,7 +1844,8 @@ static struct pci_ops brcm7425_pcie_ops = {`
`1844`	`1844`
`1845`	`1845`	`static int brcm_pcie_probe(struct platform_device *pdev)`
`1846`	`1846`	`{`
`1847`		`- struct device_node np = pdev->dev.of_node, msi_np;`
	`1847`	`+ struct device_node *msi_np __free(device_node) = NULL;`
	`1848`	`+ struct device_node *np = pdev->dev.of_node;`
`1848`	`1849`	`struct pci_host_bridge *bridge;`
`1849`	`1850`	`const struct pcie_cfg_data *data;`
`1850`	`1851`	`struct brcm_pcie *pcie;`