builder function running before custom event

[emiliosh]

Hi, in the previous version of Datatables I had a custom filter trait wich allows to use my own filters in some special cases. I have a Page component managing my filters (combos, searchs, reset) and inside a Rappasoft Datatable who receives the filter thru an event. In that previous version looks like the order my code run is:

1. MyPage runs emit('setCustomFilter')
2. MyTable runs setCustomFilter
3. MyTable runs query

But in this new versión

1. MyPage runs emit('setCustomFilter')
2. MyTable runs builder
3. MyTable runs setCustomFilter

My code is:

CustomFilterTable Trait

<?php

namespace App\Traits;

trait CustomFilterTable
{
    public array $customFilter = [];

    public function mountCustomFilterTable(array $customFilter = null)
    {
        if (! is_null($customFilter)) {
            $this->customFilter = $customFilter;
        }
    }

    protected function getCustomFilter($property)
    {
        if (! empty($this->customFilter[$property])) {
            return $this->customFilter[$property];
        }

        return false;
    }

    protected function getListeners()
    {
        $result = parent::getListeners();
        $result['setCustomFilter'] = 'setCustomFilter';

        return $result;
    }

    public function setCustomFilter($customFilter)
    {
        $this->customFilter = $customFilter;
        $this->resetPage();
    }
}

[emiliosh]

I guess is because of

    public function booted(): void
    {
        $this->configure();
        $this->setTheme();
        $this->setBuilder($this->builder());
        $this->setColumns();

        // Make sure a primary key is set
        if (! $this->hasPrimaryKey()) {
            throw new DataTableConfigurationException('You must set a primary key using setPrimaryKey in the configure method.');
        }
    }

in DataTableComponent that setBuilder line. But don't understand why is working like this.

Maybe I lost the meaning and reason of the new builder function.

[emiliosh]

My old query (and new builder) function do a lot of conditional stuff checking for my getCustomFilter. I can imagine if I am able to change this "if" sentences to Eloquent "when" will do the job. Maybe this way it will run as intended. But for now I will cancel my upgrade to Datatable v2.

    public function builder(): Builder
    {
        $exist_f_amortizada = 0;
        $exist_f_adj_vop_ocu = 0;
        $fecha_ini = Carbon::now();
        $fecha_fin = Carbon::now();

        if ($this->getCustomFilter('date_from')) {
            $fecha_ini = $this->getCustomFilter('date_from');
        }

        if ($this->getCustomFilter('date_to')) {
            $fecha_fin = $this->getCustomFilter('date_to');
        }

        $itemlist = WorkPlace::with([
            'stafftype',
            'workplacetype',
            'workplacestates',
            'workplaceshifts',
            'workplaceofficialgfhs',
            'category',
            'currentworkplaceshift',
            'currentworkplacestate',
            'currentworkplaceofficialgfh',
            'position',
            'management'
        ])->where('real', true)
            ->whereNotIn('workplacetype_id', [4]);  //Quitar las ficticias

        if ($this->getCustomFilter('id')) {
            $itemlist->where('id', $this->getCustomFilter('id'));
        }

        if ($this->getCustomFilter('category_id')) {
            $itemlist->whereIn('category_id', $this->getCustomFilter('category_id'));
        }

        if ($this->getCustomFilter('position_id')) {
            $itemlist->whereIn('position_id', $this->getCustomFilter('position_id'));
        }

        if ($this->getCustomFilter('workplacetype_id')) {
            $itemlist->whereIn('workplacetype_id', $this->getCustomFilter('workplacetype_id'));
        }

        if ($this->getCustomFilter('stafftype_id')) {
            $itemlist->whereIn('stafftype_id', $this->getCustomFilter('stafftype_id'));
        }

        if ($this->getCustomFilter('started_note')) {
            $itemlist->where('started_note', 'ILIKE', '%'.$this->getCustomFilter('started_note').'%');
        }

        if ($this->getCustomFilter('ended_note')) {
            $itemlist->where('ended_note', 'ILIKE', '%'.$this->getCustomFilter('ended_note').'%');
        }

        if ($this->getCustomFilter('shift_id')) {
            $itemlist->whereHas('workplaceshifts',
                function (Builder $query) {
                    $query->whereIn('shift_id', $this->getCustomFilter('shift_id'))
                        ->whereNull('ended_at');
                });
        }

        if ($this->getCustomFilter('center_id')) {
            $itemlist->whereHas('currentworkplaceofficialgfh',
                function (Builder $query) {
                    $query->whereHas('officialgfh',
                        function (Builder $query2) {
                            $query2->whereIn('center_id', $this->getCustomFilter('center_id'));
                        });
                });
        }

        if ($this->getCustomFilter('service_id')) {
            $itemlist->whereHas('currentworkplaceofficialgfh',
                function (Builder $query) {
                    $query->whereHas('officialgfh',
                        function (Builder $query2) {
                            $query2->whereIn('service_id', $this->getCustomFilter('service_id'));
                        });
                });
        }

        if ($this->getCustomFilter('gfh_id')) {
            $itemlist->whereHas('currentworkplaceofficialgfh',
                function (Builder $query) {
                    $query->whereHas('officialgfh',
                        function (Builder $query2) {
                            $query2->whereIn('gfh_id', $this->getCustomFilter('gfh_id'));
                        });
                });
        }

        if ($this->getCustomFilter('management_id')) {
            $itemlist->withCurrentManagement($this->getCustomFilter('management_id'));
        } else {
            if (auth()->user()->hasPermission('workplace.management.default-filter')) {
                $itemlist->withCurrentManagement(auth()->user()->managements()->pluck('managements.id', 'managements.id')->all());
            }
        }

        if ($this->getCustomFilter('workplacestatetype_id')) {
            //Se está preguntando por estado Amortizada?
            $exist_f_adj_vop_ocu = count(WorkPlaceStateType::whereIn('id', $this->getCustomFilter('workplacestatetype_id'))->whereIn('code', ['ADJ', 'VOP', 'OCU'])->get()) > 0;
            //Se está preguntando por estado Ocupada?
            $exist_f_amortizada = count(WorkPlaceStateType::whereIn('id', $this->getCustomFilter('workplacestatetype_id'))->where('code', 'AMR')->get()) > 0;

            $itemlist->where(
                function (Builder $query) use ($exist_f_amortizada, $exist_f_adj_vop_ocu, $fecha_ini, $fecha_fin) {
                    $query = $query->whereHas('workplacestates',
                        function (Builder $query2) {
                            $query2->whereIn('workplacestatetype_id', $this->getCustomFilter('workplacestatetype_id'))
                                ->whereNull('ended_at');
                        });
                    //Si se quiere filtrar por Amortizada hay que incluir aquellas que en el periodo
                    // - hayan terminado por haber alcanzado la fecha de fin (workplace.ended_at)
                    // - y además no tengan workplacestates en ese periodo
                    if ($exist_f_amortizada) {
                        $query->orWhere(
                            function (Builder $query2) use ($fecha_fin, $fecha_ini) {
                                $query2->WhereDate('workplaces.ended_at', '>=', $fecha_ini)
                                    ->whereDoesntHave('workplacestates',
                                        function (Builder $query3) use ($fecha_ini, $fecha_fin) {
                                            $query3->whereDate('started_at', '>=', $fecha_ini)
                                                ->where(
                                                    function (Builder $query4) use ($fecha_fin) {
                                                        $query4->whereNull('ended_at')
                                                            ->orWhereDate('ended_at', '<=', $fecha_fin);
                                                    });
                                        });
                            });
                    }

                    //Si se quiere filtrar por OCU ADJ VOP hay que incluir aquellas que en el periodo
                    // - que su estado actual workplacestates sea VPU id:7 (organicas) o LIB id:2 (resto) (fecha de inicio > a filtro inicio) fecha fin nulo
                    // - y además tengan una workplacetenures (ocupación) sin fecha fin y con fecha de inicio anterior
                    //   al periodo de búsqueda
                    if ($exist_f_adj_vop_ocu) {
                        $query->orWhere(
                            function (Builder $query2) use ($fecha_ini, $fecha_fin) {
                                $query2->whereHas('workplacestates',
                                    function (Builder $query3) use ($fecha_ini) {
                                        $query3->whereDate('started_at', '<=', $fecha_ini)
                                            ->whereNull('ended_at')
                                            ->whereIn('workplacestatetype_id', [2, 7]);
                                    }
                                )->whereHas('workplacetenures',
                                    function (Builder $query3) use ($fecha_ini, $fecha_fin) {
                                        $query3->whereDate('started_at', '<=', $fecha_ini)
                                            ->whereDate('ended_at', '>=', $fecha_fin)
                                            ->orWhereNull('ended_at');
                                    }
                                );
                            }
                        );
                    }
                });
        }
        //Quitar los ELSE?
        if ($exist_f_amortizada) {
            $itemlist->where(
                function (Builder $query) use ($fecha_ini, $fecha_fin) {
                    $query->whereDate('workplaces.started_at', '>=', $fecha_ini)
                        ->where(
                            function ($q) use ($fecha_fin) {
                                $q->whereNull('workplaces.ended_at')
                                    ->orWhereDate('workplaces.ended_at', '<=', $fecha_fin);
                            });
                })->orWhere(
                function (Builder $query) use ($fecha_ini) {
                    $query->whereDate('workplaces.ended_at', '<=', $fecha_ini);
                }
            );

        //TODO: PREGUNTAR POR WORKPLACERESERVED SI SE PREGUNTA POR VOPB
        } elseif ($exist_f_adj_vop_ocu) {
            //TODO: PREGUNTAR SI EXISTE WORKPLACETENURE O PROPOSAL EN EL PERIODO
        } else {
            $itemlist->whereDate('workplaces.started_at', '>=', $fecha_ini)
                ->where(function ($q) use ($fecha_fin) {
                    $q->whereNull('workplaces.ended_at')
                        ->orWhereDate('workplaces.ended_at', '<=', $fecha_fin);
                });
        }

        return $itemlist;
    }

PS: I hope @rappasoft will read me. Thanks in advance.