From 5ff8ca84c8c9a44d63847fd042f2c3ca0d9fd73d Mon Sep 17 00:00:00 2001 From: Jade Geels Date: Mon, 21 Oct 2024 13:48:35 +0200 Subject: [PATCH 1/3] Reduce javascript bundle size from 290kB to 156kB --- resources/js/components/Graphql.vue | 4 ++-- resources/js/package.js | 4 ++-- resources/js/turbolinks.js | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/resources/js/components/Graphql.vue b/resources/js/components/Graphql.vue index e16a537a2..7768b4cb9 100644 --- a/resources/js/components/Graphql.vue +++ b/resources/js/components/Graphql.vue @@ -15,7 +15,7 @@ export default { default: () => ({}), }, check: { - type: String, + type: Function, }, redirect: { type: String, @@ -80,7 +80,7 @@ export default { let response = await window.magentoGraphQL(this.query, this.variables, options) if (this.check) { - if (!eval('response.data.' + this.check)) { + if (! this.check(response.data)) { Turbo.visit(window.url(this.redirect)) return } diff --git a/resources/js/package.js b/resources/js/package.js index f5c95b508..6f8e5dc6e 100644 --- a/resources/js/package.js +++ b/resources/js/package.js @@ -14,15 +14,15 @@ import useMask from './stores/useMask' import { swatches, clear as clearSwatches } from './stores/useSwatches' import { clear as clearAttributes } from './stores/useAttributes.js' import './vue' -import { computed } from 'vue' import './fetch' import './filters' import './mixins' -import './turbolinks' import './cookies' import './callbacks' import './vue-components' +(() => import('./turbolinks'))() + function init() { // https://vuejs.org/api/application.html#app-config-performance Vue.config.performance = import.meta.env.VITE_PERFORMANCE == 'true' diff --git a/resources/js/turbolinks.js b/resources/js/turbolinks.js index 4b04e3323..b37705119 100644 --- a/resources/js/turbolinks.js +++ b/resources/js/turbolinks.js @@ -3,4 +3,4 @@ import * as Turbo from '@hotwired/turbo' import TurbolinksAdapter from 'vue-turbolinks' Vue.use(TurbolinksAdapter) -Turbo.setProgressBarDelay(5) +Turbo.config.drive.progressBarDelay = 5 From f3e707aeab6694159bb936467ea591765c31023a Mon Sep 17 00:00:00 2001 From: Jade-GG Date: Mon, 21 Oct 2024 11:49:35 +0000 Subject: [PATCH 2/3] Apply fixes from Prettier --- resources/js/components/Graphql.vue | 2 +- resources/js/package.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/js/components/Graphql.vue b/resources/js/components/Graphql.vue index 7768b4cb9..d2d76cd38 100644 --- a/resources/js/components/Graphql.vue +++ b/resources/js/components/Graphql.vue @@ -80,7 +80,7 @@ export default { let response = await window.magentoGraphQL(this.query, this.variables, options) if (this.check) { - if (! this.check(response.data)) { + if (!this.check(response.data)) { Turbo.visit(window.url(this.redirect)) return } diff --git a/resources/js/package.js b/resources/js/package.js index 6f8e5dc6e..e8f9e2742 100644 --- a/resources/js/package.js +++ b/resources/js/package.js @@ -21,7 +21,7 @@ import './cookies' import './callbacks' import './vue-components' -(() => import('./turbolinks'))() +;(() => import('./turbolinks'))() function init() { // https://vuejs.org/api/application.html#app-config-performance From d6d7696a3a116387fc53837092e7328e6b414890 Mon Sep 17 00:00:00 2001 From: rapidez-actions Date: Mon, 21 Oct 2024 11:50:27 +0000 Subject: [PATCH 3/3] Apply fixes from Prettier --- resources/js/package.js | 1 - 1 file changed, 1 deletion(-) diff --git a/resources/js/package.js b/resources/js/package.js index e8f9e2742..7d2efb7a7 100644 --- a/resources/js/package.js +++ b/resources/js/package.js @@ -20,7 +20,6 @@ import './mixins' import './cookies' import './callbacks' import './vue-components' - ;(() => import('./turbolinks'))() function init() {