Fix references to LDAP Datastore Options #20262
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the module's description needs updated |
bwatters-r7
commented
May 29, 2025
Co-authored-by: Brendan <bwatters@rapid7.com>
|
This is crashing with network errors but they're unrelated to the changes in this PR. If you apply this patch however I can test these changes by showing that it's successfully binding to the target LDAP server. diff --git modules/auxiliary/gather/vmware_vcenter_vmdir_ldap.rb modules/auxiliary/gather/vmware_vcenter_vmdir_ldap.rb
index ac48322022..3fa1f789db 100644
--- modules/auxiliary/gather/vmware_vcenter_vmdir_ldap.rb
+++ modules/auxiliary/gather/vmware_vcenter_vmdir_ldap.rb
@@ -102,9 +102,16 @@ class MetasploitModule < Msf::Auxiliary
# HACK: Stash discovered base DN in CheckCode reason
Exploit::CheckCode::Vulnerable(base_dn)
end
+ rescue Errno::ECONNRESET
+ fail_with(Failure::Disconnected, 'The connection was reset.')
+ rescue Rex::ConnectionError => e
+ fail_with(Failure::Unreachable, e.message)
+ rescue Rex::Proto::Kerberos::Model::Error::KerberosError => e
+ fail_with(Failure::NoAccess, e.message)
+ rescue Rex::Proto::LDAP::LdapException => e
+ fail_with(Failure::NoAccess, e.message)
rescue Net::LDAP::Error => e
- print_error("#{e.class}: #{e.message}")
- Exploit::CheckCode::Unknown
+ fail_with(Failure::Unknown, "#{e.class}: #{e.message}")
end
def pillage(entries) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20259
Replaces old datastore options with new datastore options.