post/windows/manage/rpcapd_start: run_rpcapd(cmdline) method does not run rpcapd with cmdline

[bcoles]

The post/windows/manage/rpcapd_start module describes p and prog parameters to be used in the run_rpcapd method.

metasploit-framework/modules/post/windows/manage/rpcapd_start.rb

Lines 63 to 87 in b5129fe

	prog = get_env('ProgramFiles') << '\\winpcap\\rpcapd.exe'
	if start_type != START_TYPE_AUTO
	print_status("Setting rpcapd as 'auto' service")
	service_change_startup('rpcapd', START_TYPE_AUTO)
	end
	if datastore['ACTIVE']
	if datastore['RHOST'].nil?
	print_error('RHOST is not set ')
	return
	end
	p = prog << " -d -a #{datastore['RHOST']},#{datastore['PORT']} -v "
	print_status("Installing rpcap in ACTIVE mode (remote port: #{datastore['PORT']})")
	else
	fw_enable(prog)
	print_status("Installing rpcap in PASSIVE mode (local port: #{datastore['PORT']}) ")
	p = prog << " -d -p #{datastore['PORT']} "
	end
	if datastore['NULLAUTH']
	p << '-n'
	end
	run_rpcapd(p)
	end

The program file path prog is used to add a firewall rule. The p value is unused, then passed to the run_rpcapd method as cmdline, where it is used only in a print message:

metasploit-framework/modules/post/windows/manage/rpcapd_start.rb

Lines 89 to 98 in b5129fe

	def run_rpcapd(cmdline)
	service_name = 'rpcapd'
	if service_restart(service_name)
	print_good("Rpcapd started successfully: #{cmdline}")
	else
	print_error('There was an error restarting rpcapd.exe.')
	end
	rescue StandardError => e
	print_error("The following error was encountered: #{e.class} #{e}")
	end

Perhaps the intention was for users to manually run the command printed to terminal? The module does not do it. Despite claiming that it is installing pcap in passive or active mode, no action is taken:

metasploit-framework/modules/post/windows/manage/rpcapd_start.rb

Lines 74 to 80 in b5129fe

	p = prog << " -d -a #{datastore['RHOST']},#{datastore['PORT']} -v "
	print_status("Installing rpcap in ACTIVE mode (remote port: #{datastore['PORT']})")
	else
	fw_enable(prog)
	print_status("Installing rpcap in PASSIVE mode (local port: #{datastore['PORT']}) ")
	p = prog << " -d -p #{datastore['PORT']} "
	end