fix bugs when missing rpc reply

Author: random-zebra

src/misc.py

@@ -343,13 +343,24 @@ def printDbg_msg(what):
     return log_line
 
 
+def printError_msg(what):
+    what = clean_for_html(what)
+    timestamp = time.strftime('%Y-%m-%d %H:%M:%S', time.gmtime(now()))
+    log_line = '<b style="color: yellow">{}</b> : <em style="color: red">{}</em><br>'.format(timestamp, what)
+    return log_line
+
+
 
 def printDbg(what):
     log_line = printDbg_msg(what)
     append_to_logfile(log_line)
     print(log_line)
 
-    
+
+def printError(what):
+    log_line = printError_msg(what)
+    append_to_logfile(log_line)
+    print(log_line)
 
 
 def printException_msg(

src/qt/dlg_findCollTx.py

@@ -83,7 +83,6 @@ def load_utxos_thread(self, ctrl):
                     self.apiConnected = True
                     self.blockCount = self.mainTab.caller.rpcClient.getBlockCount()
                     utxos = self.mainTab.caller.apiClient.getAddressUtxos(self.pivx_addr)['unspent_outputs']
-                    printDbg("loading utxos\nblockCount=%s\n%s" % (str(self.blockCount), str(self.utxos)))
                     self.utxos = [utxo for utxo in utxos if round(int(utxo.get('value', 0))/1e8, 8) == 10000.00000000 ]
 
                 except Exception as e:

src/qt/dlg_sweepAll.py

@@ -77,7 +77,11 @@ def display_utxos(self):
 
         # update fee per Kb
         if self.main_tab.caller.rpcConnected:
-            self.feePerKb = self.main_tab.caller.rpcClient.getFeePerKb()  
+            self.feePerKb = self.main_tab.caller.rpcClient.getFeePerKb()
+            if self.feePerKb is None:
+                self.feePerKb = MINIMUM_FEE
+        else:
+            self.feePerKb = MINIMUM_FEE
 
         def item(value):
             item = QTableWidgetItem(value)
@@ -211,6 +215,8 @@ def FinishSend(self, serialized_tx, amount_to_send):
 
                 else:
                     decodedTx = self.main_tab.caller.rpcClient.decodeRawTransaction(tx_hex)
+                    if decodedTx is None:
+                        raise Exception("Unable to decode TX - connection to RPC server lost.")
                     destination = decodedTx.get("vout")[0].get("scriptPubKey").get("addresses")[0]
                     amount = decodedTx.get("vout")[0].get("value")
                     message = '<p>Broadcast signed transaction?</p><p>Destination address:<br><b>%s</b></p>' % destination
@@ -223,6 +229,8 @@ def FinishSend(self, serialized_tx, amount_to_send):
                     reply = mess1.exec_()
                     if reply == QMessageBox.Yes:
                         txid = self.main_tab.caller.rpcClient.sendRawTransaction(tx_hex, self.useSwiftX())
+                        if txid is None:
+                            raise Exception("Unable to send TX - connection to RPC server lost.")
                         mess2_text = "<p>Transaction successfully sent.</p>"
                         mess2 = QMessageBox(QMessageBox.Information, 'transaction Sent', mess2_text)
                         mess2.setDetailedText(txid)
@@ -235,7 +243,7 @@ def FinishSend(self, serialized_tx, amount_to_send):
 
             except Exception as e:
                 err_msg = "Exception in FinishSend"
-                printException(getCallerName(), getFunctionName(), err_msg, e.args)
+                printException(getCallerName(), getFunctionName(), err_msg, e)
 
 
 

src/tabRewards.py

@@ -11,7 +11,7 @@
 from apiClient import ApiClient
 from constants import MPATH, MINIMUM_FEE
 from hwdevice import DisconnectedException
-from misc import printDbg, printException, getCallerName, getFunctionName, persistCacheSetting, myPopUp, myPopUp_sb
+from misc import printDbg, printError, printException, getCallerName, getFunctionName, persistCacheSetting, myPopUp, myPopUp_sb
 from qt.gui_tabRewards import TabRewards_gui
 from threads import ThreadFuns
 from utils import checkPivxAddr
@@ -74,6 +74,10 @@ def display_mn_utxos(self):
         # update fee
         if self.caller.rpcConnected:
             self.feePerKb = self.caller.rpcClient.getFeePerKb()
+            if self.feePerKb is None:
+                self.feePerKb = MINIMUM_FEE
+        else:
+            self.feePerKb = MINIMUM_FEE
 
         rewards = self.caller.parent.db.getRewardsList(self.curr_name)
         self.updateTotalBalance(rewards)
@@ -188,24 +192,23 @@ def load_utxos_thread(self, ctrl):
 
             # If rpc is not connected warn and return.
             if not self.caller.rpcConnected:
-                printDbg('PIVX daemon not connected - Unable to update UTXO list')
+                printError('PIVX daemon not connected - Unable to update UTXO list')
                 return
 
             api_status = self.caller.apiClient.getStatus()
             if  api_status != 200:
-                printDbg("Wrong response from API client. Status: %s" % api_status)
+                printError("Wrong response from API client. Status: %s" % api_status)
                 return
 
             self.apiConnected = True
-            self.blockCount = self.caller.rpcClient.getBlockCount()
 
             for mn in self.caller.masternode_list:
                 # Load UTXOs from API client
                 rewards = self.caller.apiClient.getAddressUtxos(
                     mn['collateral'].get('address'))['unspent_outputs']
 
                 if rewards is None:
-                    printDbg('Error occurred while calling getaddressutxos method.')
+                    printError('API client not responding.')
                     return
 
                 # for each UTXO
@@ -215,7 +218,7 @@ def load_utxos_thread(self, ctrl):
 
                     # Don't save UTXO if raw TX is unavailable
                     if rawtx is None:
-                        printDbg("Unable to get raw TX with hash=%s from RPC server" % utxo['tx_hash'])
+                        printError("Unable to get raw TX with hash=%s from RPC server" % utxo['tx_hash'])
                         continue
 
                     # Add mn_name and raw_tx to UTXO and save it to DB
@@ -412,6 +415,8 @@ def FinishSend(self, serialized_tx, amount_to_send):
 
                 else:
                     decodedTx = self.caller.rpcClient.decodeRawTransaction(tx_hex)
+                    if decodedTx is None:
+                        raise Exception("Unable to decode TX - connection to RPC server lost.")
                     destination = decodedTx.get("vout")[0].get("scriptPubKey").get("addresses")[0]
                     amount = decodedTx.get("vout")[0].get("value")
                     message = '<p>Broadcast signed transaction?</p><p>Destination address:<br><b>%s</b></p>' % destination
@@ -424,6 +429,9 @@ def FinishSend(self, serialized_tx, amount_to_send):
                     reply = mess1.exec_()
                     if reply == QMessageBox.Yes:                
                         txid = self.caller.rpcClient.sendRawTransaction(tx_hex, self.useSwiftX())
+                        if txid is None:
+                            raise Exception("Unable to send TX - connection to RPC server lost.")
+                        
                         mess2_text = "<p>Transaction successfully sent.</p>"
                         mess2 = QMessageBox(QMessageBox.Information, 'transaction Sent', mess2_text)
                         mess2.setDetailedText(txid)