test : add coverage for project namespace tracker

Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>

Author: alexandreLamarre

internal/helm-project-operator/controllers/namespace/integration.go

@@ -3,14 +3,17 @@ package namespace
 import (
 	"context"
 	"fmt"
+	"time"
 
 	. "github.com/kralicky/kmatch"
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
+	v1alpha1 "github.com/rancher/prometheus-federator/internal/helm-project-operator/apis/helm.cattle.io/v1alpha1"
 	"github.com/rancher/prometheus-federator/internal/helm-project-operator/controllers/common"
 	"github.com/rancher/prometheus-federator/internal/helm-project-operator/controllers/setup"
 	"github.com/rancher/prometheus-federator/internal/helmcommon/pkg/crds"
 	"github.com/rancher/prometheus-federator/internal/test"
+	"github.com/samber/lo"
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
@@ -168,6 +171,117 @@ func MultiNamespaceTest(
 				Eventually(projectGetter.IsProjectRegistrationNamespace(dummyRegistrationNamespace)).Should(BeTrue())
 			})
 
+			Specify("when we add namespaces to a project", func() {
+				By("manually adding namespaces to a project")
+
+				nss := []*corev1.Namespace{
+					{
+						ObjectMeta: metav1.ObjectMeta{
+							Name: fmt.Sprintf("project-%s-ns-1", targetProjectId),
+							Labels: map[string]string{
+								opts.ProjectLabel: targetProjectId,
+							},
+						},
+					},
+					{
+						ObjectMeta: metav1.ObjectMeta{
+							Name: fmt.Sprintf("project-%s-ns-2", targetProjectId),
+							Labels: map[string]string{
+								opts.ProjectLabel: targetProjectId,
+							},
+						},
+					},
+				}
+				for _, ns := range nss {
+					t.ObjectTracker().Add(ns)
+					Expect(t.K8sClient().Create(t.Context(), ns)).To(Succeed())
+				}
+
+				By("verifying the project getter tracks them correctly")
+				Eventually(func() []string {
+					tracker, err := projectGetter.GetTargetProjectNamespaces(&v1alpha1.ProjectHelmChart{
+						ObjectMeta: metav1.ObjectMeta{
+							Namespace: fmt.Sprintf(common.ProjectRegistrationNamespaceFmt, targetProjectId),
+						},
+					})
+					if err != nil {
+						return []string{err.Error()}
+					}
+					return tracker
+				}).Should(ConsistOf(
+					lo.Map(nss, func(ns *corev1.Namespace, _ int) string {
+						return ns.Name
+					}),
+				))
+
+				Consistently(func() []string {
+					tracker, err := projectGetter.GetTargetProjectNamespaces(&v1alpha1.ProjectHelmChart{
+						ObjectMeta: metav1.ObjectMeta{
+							Namespace: fmt.Sprintf(common.ProjectRegistrationNamespaceFmt, targetProjectId),
+						},
+					})
+					if err != nil {
+						return []string{err.Error()}
+					}
+					return tracker
+				}, 1*time.Second, 200*time.Millisecond).Should(ConsistOf(
+					lo.Map(nss, func(ns *corev1.Namespace, _ int) string {
+						return ns.Name
+					}),
+				))
+			})
+
+			Specify("when we delete the namespaces associated to a project", func() {
+
+				By("manually deleting namespaces associated to a project")
+				nss := []*corev1.Namespace{
+					{
+						ObjectMeta: metav1.ObjectMeta{
+							Name: fmt.Sprintf("project-%s-ns-1", targetProjectId),
+							Labels: map[string]string{
+								opts.ProjectLabel: targetProjectId,
+							},
+						},
+					},
+					{
+						ObjectMeta: metav1.ObjectMeta{
+							Name: fmt.Sprintf("project-%s-ns-2", targetProjectId),
+							Labels: map[string]string{
+								opts.ProjectLabel: targetProjectId,
+							},
+						},
+					},
+				}
+				for _, ns := range nss {
+					Expect(t.K8sClient().Delete(t.Context(), ns)).To(Succeed())
+				}
+
+				By("verifying the project getter stops tracking them")
+				Eventually(func() []string {
+					tracker, err := projectGetter.GetTargetProjectNamespaces(&v1alpha1.ProjectHelmChart{
+						ObjectMeta: metav1.ObjectMeta{
+							Namespace: fmt.Sprintf(common.ProjectRegistrationNamespaceFmt, targetProjectId),
+						},
+					})
+					if err != nil {
+						return []string{err.Error()}
+					}
+					return tracker
+				}).Should(ConsistOf([]string{}))
+
+				Consistently(func() []string {
+					tracker, err := projectGetter.GetTargetProjectNamespaces(&v1alpha1.ProjectHelmChart{
+						ObjectMeta: metav1.ObjectMeta{
+							Namespace: fmt.Sprintf(common.ProjectRegistrationNamespaceFmt, targetProjectId),
+						},
+					})
+					if err != nil {
+						return []string{err.Error()}
+					}
+					return tracker
+				}, 1*time.Second, 200*time.Millisecond).Should(ConsistOf([]string{}))
+			})
+
 			Specify("when we delete the project registration namespace, it should cleanup related resources", func() {
 				dummyRegistrationNamespace := &corev1.Namespace{
 					ObjectMeta: metav1.ObjectMeta{
@@ -181,11 +295,11 @@ func MultiNamespaceTest(
 				By("verifying the registration namespace is deleted")
 
 				Eventually(Object(dummyRegistrationNamespace)).ShouldNot(Exist())
-				Consistently(Object(dummyRegistrationNamespace)).ShouldNot(Exist())
+				Consistently(Object(dummyRegistrationNamespace), 1*time.Millisecond*50).ShouldNot(Exist())
 
 				By("verifying the tracker eventually stops tracking the namespace")
 				Eventually(projectGetter.IsProjectRegistrationNamespace(dummyRegistrationNamespace)).Should(BeFalse())
-				Consistently(projectGetter.IsProjectRegistrationNamespace(dummyRegistrationNamespace)).Should(BeFalse())
+				Consistently(projectGetter.IsProjectRegistrationNamespace(dummyRegistrationNamespace), 1*time.Second, 10*time.Millisecond).Should(BeFalse())
 			})
 		})
 	}

internal/helm-project-operator/controllers/project/integration.go

@@ -0,0 +1,87 @@
+package project
+
+import (
+	"context"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+	"github.com/rancher/prometheus-federator/internal/helm-project-operator/apis/helm.cattle.io/v1alpha1"
+	"github.com/rancher/prometheus-federator/internal/helm-project-operator/controllers/common"
+	"github.com/rancher/prometheus-federator/internal/helm-project-operator/controllers/namespace"
+	"github.com/rancher/prometheus-federator/internal/helm-project-operator/controllers/setup"
+	"github.com/rancher/prometheus-federator/internal/test"
+	// . "github.com/kralicky/kmatch"
+)
+
+func ProjectControllerTest(
+	operatorNamespace string,
+	opts common.Options,
+	valuesOverride v1alpha1.GenericMap,
+	projectGetter namespace.ProjectGetter,
+) func() {
+	return func() {
+		var (
+			t              test.TestInterface
+			stopController context.CancelFunc
+			appCtx         *setup.AppContext
+		)
+		BeforeAll(func() {
+			t = test.GetTestInterface()
+
+			a, err := setup.NewAppContext(t.ClientConfig(), operatorNamespace, opts)
+			Expect(err).To(Succeed())
+			appCtx = a
+
+		})
+
+		When("the controller is not yet initialized", func() {
+			It("should correctly index the rolebinding cache on initialization", func() {
+				Register(
+					t.Context(),
+					operatorNamespace,
+					opts,
+					valuesOverride,
+					appCtx.Apply,
+					// watches
+					appCtx.ProjectHelmChart(),
+					appCtx.ProjectHelmChart().Cache(),
+					appCtx.Core.ConfigMap(),
+					appCtx.Core.ConfigMap().Cache(),
+					appCtx.RBAC.Role(),
+					appCtx.RBAC.Role().Cache(),
+					appCtx.RBAC.ClusterRoleBinding(),
+					appCtx.RBAC.ClusterRoleBinding().Cache(),
+					// watches and generates
+					appCtx.HelmController.HelmChart(),
+					appCtx.HelmLocker.HelmRelease(),
+					appCtx.Core.Namespace(),
+					appCtx.Core.Namespace().Cache(),
+					appCtx.RBAC.RoleBinding(),
+					appCtx.RBAC.RoleBinding().Cache(),
+					projectGetter,
+				)
+
+				// TODO : https://github.com/rancher/prometheus-federator/pull/166
+				By("verifying registed role bindings")
+
+				By("starting all controllers")
+				ctxca, ca := context.WithCancel(t.Context())
+				stopController = ca
+				go appCtx.Start(ctxca)
+			})
+		})
+
+		When("the controller is running", func() {
+			It("should do something", func() {
+			})
+		})
+
+		AfterAll(func() {
+			if stopController != nil {
+				stopController()
+			}
+			t.ObjectTracker().DeleteAll()
+		})
+
+	}
+}