Skip to content

Commit 097d9a8

Browse files
mallardduckalexandreLamarre
authored andcommitted
Squash from 57444ba..efff7a3
Fix bug when finding project root Pick the last tag instead of the first one Allow setting GIT_TAG externally too and set on workflow based on tags Fix install-federator e2e CI to use proper method for current charts Rewrite a few e2e scripts to be timeout based loops Add local-e2e target script matching current GHA workflow Remove unnecessary wait for data steps w/ new script Correct dev branch tags Refactor another e2e script to use timeout loop more shellcheck Move timeout onto correct step Fix success condition of alerts script try e2e without branch tags script Seed image name for testing via versions script Add TAG env back to e2e workflow Refactor another script for wait loop Fix inconsistent case of strings Also make sure that Prom Targets are in the "up" state Adds missing parameters to the commands in */developing.md fix(ci): Correct k3s version used for e2e testing (#172) * Add min/max k3s version used for testing I'm adding both so in the future we can test both extremes, but for now I'm going to PR just using 1 of them. * go generate * Add helper script to grab K3S versions as ENVs and use that in local-e2e * Make debug output actually create envs that should work in GHA instead of just human debug output * Source k3s version from `build.yaml` for GHA too * Fix job step ordering so yq will be installed when k3s version env is set * remove conflicting and unused ids * Fix helm-locker yq step * Export tag style of k3s versions * Use tags directly in GHA update libraries & dependencies to k8s 1.32 Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> add updated helm-locker Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> add updated helm-project-operator Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> Add node identification to internal package Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> Add internal helmcommon package to manage crds Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> update helm-locker to use shared crds abstraction Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> update helm-project-operator to use shared crds abstraction Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> update older sub-packages Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> update main functions slightly rework crd management Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> update go generate targets Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> update to go 1.23 run go mod tidy Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> update golangci-lint Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> remove internal go sub modules Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> update controller & crd generation Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> Run go generate Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> update helm-project-operator with new generated code Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> fix crd generation path Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> tweak test labels Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> run go generate Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> update images to go 1.23 Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> simplify dev scripts Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> remove dapper from Makefile Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> [WIP] simplify CI Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> vendor chart data in public package Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> update integration workflow again Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> use upstream helm during image builds Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> [WIP] importing images for integration CI Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> fix integration testing Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> [temp] disable validate-ci Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> lint fixes Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> Add back deprecated flag logic Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> remove unecessary CI stuff Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> update helm-project-operator build-chart destination Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> make crd management consistent with existing flags and add tests Signed-off-by: Alexandre Lamarre <alex7285@gmail.com> update unit test command to exclude integration tests Signed-off-by: Alexandre Lamarre <alex7285@gmail.com> Add helm-project-operator chart to examples dir Signed-off-by: Alexandre Lamarre <alex7285@gmail.com> update path for HPO chart in integration tests Signed-off-by: Alexandre Lamarre <alex7285@gmail.com> revert public pkg/chart package Signed-off-by: Alexandre Lamarre <alex7285@gmail.com> vendor correct helm-controller dependencies Signed-off-by: Alexandre Lamarre <alex7285@gmail.com> update wrangler/go toolchain Signed-off-by: Alexandre Lamarre <alex7285@gmail.com> remove helm-locker e2e CI Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> bump rancher/klipper-helm to v0.9.4-build20250113 Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> add KUBECONFIG to version script Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> add back embedded controller name logic Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> Empty-Commit rename internal/helm-locker/pkg -> internal/helm-locker Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> rename internal/helm-project-operator/pkg -> internal/helm-project-operator Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> centralize cmd version Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> update golangci-lint config Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> bump integration test k3s matrix [1.30.9, 1.32.1] Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> feat: Update Rancher Project Monitoring to use upstream 66.7.1 (#173) * Update Rancher Project Monitoring to use 0.5.0 chart version that matches Monitoring 66.7.1 * go generate * bump RPM version for small version fix * go generate * fix local-e2e bug * fix ci artifact file name * (test) expand CI wait time * fix: consistently use KUBECTL_WAIT_TIMEOUT * Make install line more readable * Every supported k3s/rke2 versions should have it disabled * make all helm install steps uniform * Capture more details about Project Monitoring install task * expand timeouts for scripts * Update shell for kuberlr-kubectl * Adjust alerts validation script Add initial Renovate configuration (#149) Co-authored-by: renovate-rancher[bot] <119870437+renovate-rancher[bot]@users.noreply.github.com> Pin dependencies Migrate config .github/renovate.json remove dapper Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> Update Docker File Deps manually downgrade to go 1.23 Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> ci: Improve ability to use CI in forks & fix multiple tag bug (#189) * Add empty for debug * fix all runs-on to be dynamic * only read vault secrets when repo matches rancher/prom-fed * Install YQ only in GHA runners where YQ isn't available * Ensure package-helm uses the current tag for chart versioning * fix runs-on format to respect matrix.arch Adjust Alertmanager E2E verification to allow common alerts (#190) * Adjust Alertmanager E2E verification to allow InfoInhibitor & PrometheusOutOfOrderTimestamps * Make helm repo url configurable * Simplify checks to verify based on count vs (count - expected) feat (renovate) : add gomod deps to renovate config target specific release branches to match rancher releases remove legacy branch v0.x from renovate bumps Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> Update GitHub Workflow Actions feat (ci): pass in rancher monitoring version Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> ci: Fix build for dev (#209) * Fix util-team-charts * Fix source url to use githubusercontent * Adjust new var names and add defaults * Correct for commented out defaults fix grep for lines starting with "#" (#222) fix(chart): patch clean up job for CRD bug (#194) * patch clean up job for CRD bug * adjust for sh syntax * fix yaml syntax (use | to make it multiline by default) Add logs to release controller Add more debug logs Fix erroring CI Fix project registration namespace error Improve fix Add logs to release controller Minor improvements Add namespace tracker initialization config to charts Add namespace tracker initialization config to example charts Add namespace tracker initialization config to runtime struct, minor fixes Fix lint error Test for nil helmRelease Fix wrong reference in example chart Update reference to helm-project-operator Fix references to namespaceRegistrationWorkers Remove empty debug Aesthetic changes to values.yaml update readme for proper branching (#232) Adjust branch rules for 3.x branch (#234) fix (dev) : adjust helm chart version to use build metadata to encode commit info Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> chore (lint) : update golangci-lint to version 2.0.2 Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com> waits for cache sync while cache population Add ability to configure PromFed Priority class (#195)
1 parent 57444ba commit 097d9a8

File tree

178 files changed

+6115
-4866
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

178 files changed

+6115
-4866
lines changed

.github/renovate.json

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,32 @@
88
"main",
99
"release/v3.x",
1010
"release/v2.x",
11-
"release/v1.x",
12-
"release/v0.x"
11+
"release/v1.x"
1312
],
1413
"enabledManagers": [
1514
"dockerfile",
1615
"github-actions",
1716
"helm-values",
18-
"regex"
17+
"custom.regex",
18+
"gomod"
1919
],
2020
"packageRules": [
21+
{
22+
"matchBaseBranches" : ["main"],
23+
"extends" : ["github>rancher/renovate-config:rancher-main#release"]
24+
},
25+
{
26+
"matchBaseBranches" : ["release/v3.x"],
27+
"extends" : ["github>rancher/renovate-config:rancher-2.11#release"]
28+
},
29+
{
30+
"matchBaseBranches" : ["release/v2.x"],
31+
"extends" : ["github>rancher/renovate-config:rancher-2.10#release"]
32+
},
33+
{
34+
"matchBaseBranches": ["release/v1.x"],
35+
"extends" : ["github>rancher/renovate-config:rancher-2.9#release"]
36+
},
2137
{
2238
"groupName": "GitHub Workflow Actions",
2339
"groupSlug": "gha-deps",

.github/scripts/branch-tags.sh

Lines changed: 0 additions & 55 deletions
This file was deleted.

.github/workflows/prom-fed-ci.yaml renamed to .github/workflows/ci.yaml

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,18 +33,29 @@ jobs:
3333
arch:
3434
- x64
3535
- arm64
36-
runs-on : runs-on,image=ubuntu22-full-${{ matrix.arch }},runner=4cpu-linux-${{ matrix.arch }},run-id=${{ github.run_id }}
36+
runs-on: ${{ github.repository == 'rancher/prometheus-federator' && format('runs-on,image=ubuntu22-full-{1},runner=4cpu-linux-{1},run-id={0}', github.run_id, matrix.arch) || 'ubuntu-latest' }}
3737
steps:
38-
- uses: actions/checkout@v4
38+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
3939
- name : Set up Go
40-
uses: actions/setup-go@v2
40+
uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5
4141
with:
4242
go-version: '1.22'
43+
- name: Check if yq is installed
44+
id: check_yq
45+
run: |
46+
if ! command -v yq &> /dev/null; then
47+
echo "yq not found, installing..."
48+
echo "::set-output name=install_yq::true"
49+
else
50+
echo "yq is already installed"
51+
echo "::set-output name=install_yq::false"
52+
fi
4353
- name : Install YQ
54+
if: steps.check_yq.outputs.install_yq == 'true'
4455
run: |
4556
sudo wget https://github.com/mikefarah/yq/releases/download/${YQ_VERSION}/yq_linux_${{ matrix.arch == 'x64' && 'amd64' || matrix.arch }} -O /usr/bin/yq && sudo chmod +x /usr/bin/yq;
4657
- name : Install helm
47-
uses: azure/setup-helm@v3
58+
uses: azure/setup-helm@b9e51907a09c216f16ebe8536097933489208112 # v4
4859
with:
4960
token: ${{ secrets.GITHUB_TOKEN }}
5061
- name: Run CI

.github/workflows/e2e/package/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
FROM registry.suse.com/bci/golang:1.20 AS helm
1+
FROM registry.suse.com/bci/golang:1.23 AS helm
22
RUN zypper -n install git
33
RUN git -C / clone --branch release-v3.9.0 --depth=1 https://github.com/rancher/helm
44
RUN make -C /helm
55

6-
FROM registry.suse.com/bci/golang:1.20
6+
FROM registry.suse.com/bci/golang:1.23
77

88
ARG ARCH=amd64
99
ENV KUBECTL_VERSION v1.21.8

.github/workflows/e2e/scripts/cluster-args.sh

Lines changed: 2 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -8,55 +8,13 @@ cd $(dirname $0)/../../../..
88

99
case "${KUBERNETES_DISTRIBUTION_TYPE}" in
1010
"k3s")
11-
cluster_args=""
12-
kubernetes_version=$(kubectl version | grep "Server Version" | cut -d ' ' -f3)
13-
case "${kubernetes_version}" in
14-
v1.23.*)
15-
embedded_helm_controller_fixed_version="v1.23.14"
16-
if [[ $(echo ${kubernetes_version} ${embedded_helm_controller_fixed_version} | tr " " "\n" | sort -rV | head -n 1 ) == "${embedded_helm_controller_fixed_version}" ]]; then
17-
cluster_args="--set helmProjectOperator.helmController.enabled=false"
18-
fi
19-
;;
20-
v1.24.*)
21-
embedded_helm_controller_fixed_version="v1.24.8"
22-
if [[ $(echo ${kubernetes_version} ${embedded_helm_controller_fixed_version} | tr " " "\n" | sort -rV | head -n 1 ) == "${embedded_helm_controller_fixed_version}" ]]; then
23-
cluster_args="--set helmProjectOperator.helmController.enabled=false"
24-
fi
25-
;;
26-
v1.25.*)
27-
embedded_helm_controller_fixed_version="v1.25.4"
28-
if [[ $(echo ${kubernetes_version} ${embedded_helm_controller_fixed_version} | tr " " "\n" | sort -rV | head -n 1 ) == "${embedded_helm_controller_fixed_version}" ]]; then
29-
cluster_args="--set helmProjectOperator.helmController.enabled=false"
30-
fi
31-
;;
32-
esac
11+
cluster_args="--set helmProjectOperator.helmController.enabled=false"
3312
;;
3413
"rke")
3514
cluster_args=""
3615
;;
3716
"rke2")
38-
cluster_args=""
39-
kubernetes_version=$(kubectl version | grep "Server Version" | cut -d ' ' -f3)
40-
case "${kubernetes_version}" in
41-
v1.23.*)
42-
embedded_helm_controller_fixed_version="v1.23.14"
43-
if [[ $(echo ${kubernetes_version} ${embedded_helm_controller_fixed_version} | tr " " "\n" | sort -rV | head -n 1 ) == "${embedded_helm_controller_fixed_version}" ]]; then
44-
cluster_args="--set helmProjectOperator.helmController.enabled=false"
45-
fi
46-
;;
47-
v1.24.*)
48-
embedded_helm_controller_fixed_version="v1.24.8"
49-
if [[ $(echo ${kubernetes_version} ${embedded_helm_controller_fixed_version} | tr " " "\n" | sort -rV | head -n 1 ) == "${embedded_helm_controller_fixed_version}" ]]; then
50-
cluster_args="--set helmProjectOperator.helmController.enabled=false"
51-
fi
52-
;;
53-
v1.25.*)
54-
embedded_helm_controller_fixed_version="v1.25.4"
55-
if [[ $(echo ${kubernetes_version} ${embedded_helm_controller_fixed_version} | tr " " "\n" | sort -rV | head -n 1 ) == "${embedded_helm_controller_fixed_version}" ]]; then
56-
cluster_args="--set helmProjectOperator.helmController.enabled=false"
57-
fi
58-
;;
59-
esac
17+
cluster_args="--set helmProjectOperator.helmController.enabled=false"
6018
;;
6119
*)
6220
echo "KUBERNETES_DISTRIBUTION_TYPE=${KUBERNETES_DISTRIBUTION_TYPE} is unknown"

.github/workflows/e2e/scripts/create-projecthelmchart.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ if [[ "${E2E_CI}" == "true" ]]; then
1111
else
1212
kubectl apply -f ./examples/prometheus-federator/project-helm-chart.yaml
1313
fi
14-
sleep ${DEFAULT_SLEEP_TIMEOUT_SECONDS};
14+
sleep "${DEFAULT_SLEEP_TIMEOUT_SECONDS}";
1515

1616
if ! kubectl get -n cattle-monitoring-system job/helm-install-cattle-project-p-example-monitoring; then
1717
echo "ERROR: Helm Install Job for Project Monitoring Stack was never created after ${DEFAULT_SLEEP_TIMEOUT_SECONDS} seconds"

.github/workflows/e2e/scripts/entry

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,12 @@ if [[ ${DEBUG} == "true" ]]; then
1212
set -x
1313
fi
1414

15+
echo "Using rancher monitoring version : ${RANCHER_MONITORING}"
16+
17+
if [ "$RANCHER_MONITORING" != "latest" ]; then
18+
RANCHER_MONITORING_VERSION_HELM_ARGS="--version ${RANCHER_MONITORING}"
19+
fi
20+
1521
if [[ "${E2E_CI}" == "true" ]]; then
1622
KUBERNETES_DISTRIBUTION_TYPE=k3s
1723
fi
@@ -23,9 +29,11 @@ if [[ -n ${RANCHER_URL} ]] && [[ -n ${RANCHER_CLUSTER} ]] && [[ -n ${RANCHER_TOK
2329
API_SERVER_URL=${RANCHER_URL}
2430
fi
2531
API_SERVER_CURL_AUTH_HEADERS="-k -H 'Authorization: Bearer ${RANCHER_TOKEN}'"
26-
RANCHER_HELM_ARGS="--set global.cattle.url=${RANCHER_URL} --set global.cattle.clusterId=${RANCHER_CLUSTER}"
32+
RANCHER_CLUSTER_HELM_ARGS="--set global.cattle.url=${RANCHER_URL} --set global.cattle.clusterId=${RANCHER_CLUSTER}"
2733
else
2834
kubectl proxy --port=${APISERVER_PORT:-8001} 2>/dev/null &
2935
API_SERVER_URL=http://localhost:${APISERVER_PORT:-8001}
3036
sleep 5
3137
fi
38+
39+
RANCHER_HELM_ARGS="${RANCHER_CLUSTER_HELM_ARGS} ${RANCHER_MONITORING_VERSION_HELM_ARGS}"

.github/workflows/e2e/scripts/generate-artifacts.sh

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ case "${KUBERNETES_DISTRIBUTION_TYPE}" in
3434
esac
3535

3636
ARTIFACT_DIRECTORY=artifacts
37+
DESCRIBE_DIRECTORY=${ARTIFACT_DIRECTORY}/described
3738
MANIFEST_DIRECTORY=${ARTIFACT_DIRECTORY}/manifests
3839
LOG_DIRECTORY=${ARTIFACT_DIRECTORY}/logs
3940

@@ -114,3 +115,11 @@ kubectl logs deployment/cattle-project-p-example-monitoring-grafana -n cattle-pr
114115
kubectl logs deployment/cattle-project-p-example-monitoring-grafana -n cattle-project-p-example -c grafana-sc-dashboard > ${LOG_DIRECTORY}/project-monitoring/grafana_sc_dashboard.log || true
115116
kubectl logs deployment/cattle-project-p-example-monitoring-grafana -n cattle-project-p-example -c grafana-sc-datasources > ${LOG_DIRECTORY}/project-monitoring/grafana_sc_datasources.log || true
116117
kubectl logs deployment/cattle-project-p-example-monitoring-grafana -n cattle-project-p-example -c grafana-init-sc-datasources > ${LOG_DIRECTORY}/project-monitoring/grafana_init_sc_datasources.log || true
118+
119+
# Resource Descriptions
120+
121+
mkdir -p ${DESCRIBE_DIRECTORY}
122+
123+
## Additional Context
124+
kubectl describe jobs -n cattle-monitoring-system helm-install-cattle-project-p-example-monitoring > ${DESCRIBE_DIRECTORY}/project-monitoring-helm-install-job.log
125+
kubectl describe pods -n cattle-monitoring-system -l job-name=helm-install-cattle-project-p-example-monitoring > ${DESCRIBE_DIRECTORY}/project-monitoring-helm-install-pod.log

.github/workflows/e2e/scripts/install-federator.sh

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,12 @@ source $(dirname $0)/cluster-args.sh
88
cd $(dirname $0)/../../../..
99
source "$(pwd)/scripts/util-team-charts"
1010

11-
NEWEST_CHART_VERSION=$(newest-chart-version "prometheus-federator")
12-
fetch-team-chart "prometheus-federator" "$NEWEST_CHART_VERSION"
13-
LATEST_CHART_PATH="./build/charts/prometheus-federator-${NEWEST_CHART_VERSION}.tgz"
14-
tar -xvzf "$LATEST_CHART_PATH" -C ./build/charts/
11+
make package-helm
1512

16-
helm upgrade --install --create-namespace -n cattle-monitoring-system prometheus-federator --set helmProjectOperator.image.repository=${REPO:-rancher}/prometheus-federator --set helmProjectOperator.image.tag=${TAG:-dev} ${cluster_args} ${RANCHER_HELM_ARGS} ./build/charts/prometheus-federator
13+
helm upgrade --install --create-namespace -n cattle-monitoring-system prometheus-federator \
14+
--set helmProjectOperator.image.repository=${REPO:-rancher}/prometheus-federator \
15+
--set helmProjectOperator.image.tag=${TAG:-dev} \
16+
${cluster_args} \
17+
${RANCHER_HELM_ARGS} ./build/charts/prometheus-federator
1718

1819
echo "PASS: Prometheus Federator has been installed"

.github/workflows/e2e/scripts/install-monitoring.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,13 @@ set -x
55
source $(dirname $0)/entry
66

77
HELM_REPO="rancher-charts"
8+
HELM_REPO_URL="https://charts.rancher.io"
89

910
cd $(dirname $0)/../../../..
1011

1112
helm version
1213

13-
helm repo add ${HELM_REPO} https://charts.rancher.io
14+
helm repo add ${HELM_REPO} $HELM_REPO_URL
1415
helm repo update
1516

1617
echo "Create required \`cattle-fleet-system\` namespace"
@@ -20,7 +21,7 @@ echo "Installing rancher monitoring crd with :\n"
2021

2122
helm search repo ${HELM_REPO}/rancher-monitoring-crd --versions --max-col-width=0 | head -n 2
2223

23-
helm upgrade --install --create-namespace -n cattle-monitoring-system rancher-monitoring-crd ${HELM_REPO}/rancher-monitoring-crd
24+
helm upgrade --install --create-namespace -n cattle-monitoring-system ${RANCHER_MONITORING_VERSION_HELM_ARGS} rancher-monitoring-crd ${HELM_REPO}/rancher-monitoring-crd
2425

2526
if [[ "${E2E_CI}" == "true" ]]; then
2627
e2e_args="--set grafana.resources=null --set prometheus.prometheusSpec.resources=null --set alertmanager.alertmanagerSpec.resources=null"

0 commit comments

Comments
 (0)