Skip to content
This repository was archived by the owner on Jan 4, 2022. It is now read-only.

Commit 3bfc830

Browse files
mrajashreeAlena Prokharchyk
authored andcommitted
Add setting for whitelisting redirect URLs for auth
1 parent 495f488 commit 3bfc830

File tree

4 files changed

+13
-9
lines changed

4 files changed

+13
-9
lines changed

code/implementation/docker/machine/src/main/java/io/cattle/platform/docker/machine/launch/AuthServiceLauncher.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ public class AuthServiceLauncher extends GenericServiceLauncher implements Initi
5959
public static final DynamicStringProperty NO_IDENTITY_LOOKUP_SETTING = ArchaiusUtil.getString("api.auth.external.provider.no.identity.lookup");
6060
private static final DynamicStringProperty AUTH_SERVICE_LOG_LEVEL = ArchaiusUtil.getString("auth.service.log.level");
6161
private static final DynamicStringProperty AUTH_SERVICE_CONFIG_UPDATE_TIMESTAMP = ArchaiusUtil.getString("auth.service.config.update.timestamp");
62+
public static final DynamicStringProperty API_AUTH_SHIBBOLETH_REDIRECT_WHITELIST_SETTING = ArchaiusUtil.getString("api.auth.shibboleth.redirect.whitelist");
6263

6364
@Override
6465
protected boolean shouldRun() {
@@ -154,6 +155,7 @@ protected List<DynamicStringProperty> getReloadSettings() {
154155
list.add(SECURITY_SETTING);
155156
list.add(AUTH_SERVICE_LOG_LEVEL);
156157
list.add(AUTH_SERVICE_CONFIG_UPDATE_TIMESTAMP);
158+
list.add(API_AUTH_SHIBBOLETH_REDIRECT_WHITELIST_SETTING);
157159
return list;
158160
}
159161

code/packaging/app-config/src/main/resources/META-INF/cattle/api-server/defaults.properties

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,8 @@ settings.public=rancher.compose.linux.url, \
9393
ui.show.system, \
9494
ui.show.custom.host, \
9595
api.host, \
96-
ipsec.service.enable.healthcheck
96+
ipsec.service.enable.healthcheck, \
97+
api.auth.shibboleth.redirect.whitelist
9798

9899
vm.enabled=false
99100
ui.pl=rancher
@@ -103,4 +104,5 @@ engine.install.url=https://releases.rancher.com/install-docker/1.12.sh
103104
account.version=2
104105
supported.docker.range=~v1.12.3 || ~v1.13.0 || ~v17.03.0 || ~v17.06.0 || ~v17.09.0 || ~v17.12.0 || ~v18.03.0 || ~v18.06.0
105106
newest.docker.version=v18.06.0
107+
api.auth.shibboleth.redirect.whitelist=
106108
ipsec.service.enable.healthcheck=false

tests/integration-v1/cattletest/core/test_settings.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,16 +99,16 @@ def test_settings_user_list(context):
9999
names = {x.name for x in settings}
100100

101101
assert len(settings) != 0
102-
assert len(settings) < 17
102+
assert len(settings) < 18
103103
assert 'rancher.compose.linux.url' in names
104104

105105
settings = user_client.list_setting(all=True)
106106
assert len(settings) != 0
107-
assert len(settings) < 17
107+
assert len(settings) < 18
108108

109109
settings = user_client.list_setting(all=False)
110110
assert len(settings) != 0
111-
assert len(settings) < 17
111+
assert len(settings) < 18
112112

113113

114114
def test_settings_admin_user_list(admin_user_client):
@@ -124,5 +124,5 @@ def test_settings_admin_user_list(admin_user_client):
124124
names = {x.name for x in settings}
125125

126126
assert len(settings) != 0
127-
assert len(settings) < 17
127+
assert len(settings) < 18
128128
assert 'rancher.compose.linux.url' in names

tests/integration/cattletest/core/test_settings.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,16 +99,16 @@ def test_settings_user_list(context):
9999
names = {x.name for x in settings}
100100

101101
assert len(settings) != 0
102-
assert len(settings) < 17
102+
assert len(settings) < 18
103103
assert 'rancher.compose.linux.url' in names
104104

105105
settings = user_client.list_setting(all=True)
106106
assert len(settings) != 0
107-
assert len(settings) < 17
107+
assert len(settings) < 18
108108

109109
settings = user_client.list_setting(all=False)
110110
assert len(settings) != 0
111-
assert len(settings) < 17
111+
assert len(settings) < 18
112112

113113

114114
def test_settings_admin_user_list(admin_user_client):
@@ -124,7 +124,7 @@ def test_settings_admin_user_list(admin_user_client):
124124
names = {x.name for x in settings}
125125

126126
assert len(settings) != 0
127-
assert len(settings) < 17
127+
assert len(settings) < 18
128128
assert 'rancher.compose.linux.url' in names
129129

130130

0 commit comments

Comments
 (0)