EssentialTypes: Implement Rule 14.1

Adds a query that finds loop counters which are essentially floating
type.

Author: lcartey

c/misra/src/rules/RULE-14-1/LoopOverEssentiallyFloatType.ql

@@ -0,0 +1,23 @@
+/**
+ * @id c/misra/loop-over-essentially-float-type
+ * @name RULE-14-1: A loop counter shall not have essentially floating type
+ * @description
+ * @kind problem
+ * @precision high
+ * @problem.severity error
+ * @tags external/misra/id/rule-14-1
+ *       external/misra/obligation/required
+ */
+
+import cpp
+import codingstandards.c.misra
+import codingstandards.c.misra.EssentialTypes
+import codingstandards.cpp.Loops
+
+from ForStmt forLoop, Variable loopIterationVariable
+where
+  not isExcluded(loopIterationVariable, EssentialTypesPackage::loopOverEssentiallyFloatTypeQuery()) and
+  getAnIterationVariable(forLoop) = loopIterationVariable and
+  getEssentialTypeCategory(loopIterationVariable.getType()) = EssentiallyFloatingType()
+select loopIterationVariable,
+  "Loop iteration variable " + loopIterationVariable.getName() + " is essentially Floating type."

c/misra/test/rules/RULE-14-1/LoopOverEssentiallyFloatType.expected

@@ -0,0 +1,3 @@
+| test.c:4:14:4:14 | f | Loop iteration variable f is essentially Floating type. |
+| test.c:6:15:6:15 | d | Loop iteration variable d is essentially Floating type. |
+| test.c:8:18:8:18 | f | Loop iteration variable f is essentially Floating type. |

c/misra/test/rules/RULE-14-1/LoopOverEssentiallyFloatType.qlref

@@ -0,0 +1 @@
+rules/RULE-14-1/LoopOverEssentiallyFloatType.ql

c/misra/test/rules/RULE-14-1/test.c

@@ -0,0 +1,15 @@
+typedef float float32_t;
+
+void test_floating_point_loop() {
+  for (float f = 0.0F; f < 10.0F; f += 0.2F) { // NON_COMPLIANT
+  }
+  for (double d = 0.0F; d < 10.0F; d += 0.2F) { // NON_COMPLIANT
+  }
+  for (float32_t f = 0.0F; f < 10.0F; f += 0.2F) { // NON_COMPLIANT
+  }
+}
+
+void test_non_floating_point_loop() {
+  for (int i = 0; i < 10; i++) { // COMPLIANT
+  }
+}