EssentialType: Handle type specifiers

lcartey · lcartey · commit 2c106bcfdf96 · 2023-02-14T13:28:46.000Z
Ensure when calculating the essential type category, we strip the type
specifiers, otherwise we will not match the correct type category.
diff --git a/c/misra/src/codingstandards/c/misra/EssentialTypes.qll b/c/misra/src/codingstandards/c/misra/EssentialTypes.qll
@@ -79,7 +79,7 @@ private IntegralType stlr(Expr const) {
 EssentialTypeCategory getEssentialTypeCategory(Type type) {
   exists(Type essentialType |
     // Resolve typedefs to ensure
-    essentialType = type.getUnderlyingType()
+    essentialType = type.getUnspecifiedType()
   |
     result = EssentiallyBooleanType() and essentialType instanceof MisraBoolType
     or

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ private IntegralType stlr(Expr const) {`
`79`	`79`	`EssentialTypeCategory getEssentialTypeCategory(Type type) {`
`80`	`80`	`exists(Type essentialType \|`
`81`	`81`	`// Resolve typedefs to ensure`
`82`		`- essentialType = type.getUnderlyingType()`
	`82`	`+ essentialType = type.getUnspecifiedType()`
`83`	`83`	`\|`
`84`	`84`	`result = EssentiallyBooleanType() and essentialType instanceof MisraBoolType`
`85`	`85`	`or`