Add condition that requires <a> and <area> elements to have an href to be interactive

Mike Lumetta · Mike Lumetta · commit 83dba7c9c5b1 · 2020-12-09T09:53:39.000-05:00
diff --git a/src/index.js b/src/index.js
@@ -17,8 +17,10 @@ function reset() {
 }
 
 function isInteractiveElement(element) {
-  const interactiveTags = ['A', 'AREA', 'BUTTON', 'INPUT', 'SELECT', 'TEXTAREA'];
-  return interactiveTags.includes(element.tagName) && !element.hasAttribute('disabled');
+  const formTags = ['BUTTON', 'INPUT', 'SELECT', 'TEXTAREA'];
+  const linkTags = ['A', 'AREA'];
+  return (formTags.includes(element.tagName) && !element.hasAttribute('disabled'))
+    || (linkTags.includes(element.tagName) && element.hasAttribute('href'));
 }
 
 function getElAndScroll() {

Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,10 @@ function reset() {`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`function isInteractiveElement(element) {`
`20`		`- const interactiveTags = ['A', 'AREA', 'BUTTON', 'INPUT', 'SELECT', 'TEXTAREA'];`
`21`		`- return interactiveTags.includes(element.tagName) && !element.hasAttribute('disabled');`
	`20`	`+ const formTags = ['BUTTON', 'INPUT', 'SELECT', 'TEXTAREA'];`
	`21`	`+ const linkTags = ['A', 'AREA'];`
	`22`	`+ return (formTags.includes(element.tagName) && !element.hasAttribute('disabled'))`
	`23`	`+ \|\| (linkTags.includes(element.tagName) && element.hasAttribute('href'));`
`22`	`24`	`}`
`23`	`25`
`24`	`26`	`function getElAndScroll() {`