Error when appending layer to netcdf still adds a layer to the file

[tiemvanderdeure]

MWE:

using Rasters, NCDatasets
write("myfile.nc", Raster(rand(X(1:10), Y(1:10))))
write("myfile.nc", Raster(rand(X(2:10), Y(1:10)), name = :ras2), append = true)
RasterStack("myfile.nc")

The second write errors because the dimensions don't match, but before that error occurs the layer is already initalized, so we end up with an extra layer that is filled with 9.96921e36.

Probably we need a try-catch block and delete the layer again if an error occurs.

┌ 10×10 RasterStack ┐
├───────────────────┴─────────────────────────────────────────────────────────────────────────────────── dims ┐
  ↓ X Mapped{Int64} [1, 2, …, 9, 10] ForwardOrdered Regular Points,
  → Y Mapped{Int64} [1, 2, …, 9, 10] ForwardOrdered Regular Points
├───────────────────────────────────────────────────────────────────────────────────────────────────── layers ┤
  :unnamed eltype: Union{Missing, Float64} dims: X, Y size: 10×10
  :ras2    eltype: Union{Missing, Float64} dims: X, Y size: 10×10
├─────────────────────────────────────────────────────────────────────────────────────────────────── metadata ┤
  Metadata{Rasters.NCDsource} of Dict{String, Any}()
├───────────────────────────────────────────────────────────────────────────────────────────────────── raster ┤
  missingval: missing
  extent: Extent(X = (1, 10), Y = (1, 10))
└─────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

[rafaqz]

Yep, all checks should happen before we add any variables or dimensions