Skip to content

Commit 70dd1bd

Browse files
committed
Add UTC to datenow
1 parent 2d6997e commit 70dd1bd

File tree

4 files changed

+22
-22
lines changed

4 files changed

+22
-22
lines changed

radish/extensions/cucumber_json_writer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
This module provides a hook which generates a cucumber json result file at the end of the run.
55
"""
66

7-
from datetime import timedelta, datetime
7+
from datetime import timedelta, datetime, UTC
88
import json
99

1010
from radish.terrain import world
@@ -44,7 +44,7 @@ def generate_ccjson(self, features, marker):
4444
if feature.starttime is not None:
4545
# feature file run not finished
4646
if feature.endtime is None:
47-
duration += feature.starttime - datetime.utcnow()
47+
duration += feature.starttime - datetime.utcnow(UTC)
4848
# feature file run finished
4949
else:
5050
duration += feature.duration

radish/extensions/time_recorder.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
This module is a REQUIRED extension to record the time of Features, Scenarios and Steps
55
"""
66

7-
from datetime import datetime
7+
from datetime import datetime, UTC
88

99
from radish.hookregistry import after, before
1010
from radish.extensionregistry import extension
@@ -33,34 +33,34 @@ def time_recorder_before_each_feature(self, feature):
3333
"""
3434
Sets the starttime of the feature
3535
"""
36-
feature.starttime = datetime.utcnow()
36+
feature.starttime = datetime.utcnow(UTC)
3737

3838
def time_recorder_before_each_scenario(self, scenario):
3939
"""
4040
Sets the starttime of the scenario
4141
"""
42-
scenario.starttime = datetime.utcnow()
42+
scenario.starttime = datetime.utcnow(UTC)
4343

4444
def time_recorder_before_each_step(self, step):
4545
"""
4646
Sets the starttime of the step
4747
"""
48-
step.starttime = datetime.utcnow()
48+
step.starttime = datetime.utcnow(UTC)
4949

5050
def time_recorder_after_each_feature(self, feature):
5151
"""
5252
Sets the endtime of the feature
5353
"""
54-
feature.endtime = datetime.utcnow()
54+
feature.endtime = datetime.utcnow(UTC)
5555

5656
def time_recorder_after_each_scenario(self, scenario):
5757
"""
5858
Sets the endtime of the scenario
5959
"""
60-
scenario.endtime = datetime.utcnow()
60+
scenario.endtime = datetime.utcnow(UTC)
6161

6262
def time_recorder_after_each_step(self, step):
6363
"""
6464
Sets the endtime of the step
6565
"""
66-
step.endtime = datetime.utcnow()
66+
step.endtime = datetime.utcnow(UTC)

tests/unit/extensions/test_junit_xml_writer.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
import pytest
1313

14-
from datetime import datetime
14+
from datetime import datetime, UTC
1515

1616
from radish.terrain import world
1717
from radish.exceptions import RadishError
@@ -33,8 +33,8 @@ def test_singel_feature_list(mocker):
3333
stub = mocker.patch("radish.extensions.junit_xml_writer.JUnitXMLWriter._write_xml_to_disk")
3434

3535
first_feature = Feature(1, "Feature", "I am a feature", "foo.feature", 1, tags=None)
36-
first_feature.starttime = datetime.utcnow()
37-
first_feature.endtime = datetime.utcnow()
36+
first_feature.starttime = datetime.utcnow(UTC)
37+
first_feature.endtime = datetime.utcnow(UTC)
3838

3939
features = [first_feature]
4040

@@ -61,12 +61,12 @@ def test_normal_feature_list(mocker):
6161
preconditions=None,
6262
background=None,
6363
)
64-
first_scenario.starttime = datetime.utcnow()
65-
first_scenario.endtime = datetime.utcnow()
64+
first_scenario.starttime = datetime.utcnow(UTC)
65+
first_scenario.endtime = datetime.utcnow(UTC)
6666

6767
first_feature = Feature(1, "Feature", "I am a feature", "foo.feature", 1, tags=None)
68-
first_feature.starttime = datetime.utcnow()
69-
first_feature.endtime = datetime.utcnow()
68+
first_feature.starttime = datetime.utcnow(UTC)
69+
first_feature.endtime = datetime.utcnow(UTC)
7070
first_feature.scenarios.append(first_scenario)
7171

7272
features = [first_feature]
@@ -95,12 +95,12 @@ def test_relaxed_mode_adding_tags_to_junit(mocker):
9595
preconditions=None,
9696
background=None,
9797
)
98-
first_scenario.starttime = datetime.utcnow()
99-
first_scenario.endtime = datetime.utcnow()
98+
first_scenario.starttime = datetime.utcnow(UTC)
99+
first_scenario.endtime = datetime.utcnow(UTC)
100100

101101
first_feature = Feature(1, "Feature", "I am a feature", "foo.feature", 1, tags=None)
102-
first_feature.starttime = datetime.utcnow()
103-
first_feature.endtime = datetime.utcnow()
102+
first_feature.starttime = datetime.utcnow(UTC)
103+
first_feature.endtime = datetime.utcnow(UTC)
104104
first_feature.scenarios.append(first_scenario)
105105

106106
features = [first_feature]

tests/unit/test_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
Copyright: MIT, Timo Furrer <tuxtimo@gmail.com>
1010
"""
1111

12-
from datetime import datetime
12+
from datetime import datetime, UTC
1313

1414
import pytest
1515
from freezegun import freeze_time
@@ -46,7 +46,7 @@ def test_date_time_formatter():
4646
Test datetime to string format
4747
"""
4848
# given
49-
utc_dt = datetime.utcnow()
49+
utc_dt = datetime.utcnow(UTC)
5050
expected_datetime_string = "2015-10-21T05:29:00"
5151
actual_datetime_string = utils.format_utc_to_local_tz(utc_dt)
5252

0 commit comments

Comments
 (0)