Merge pull request #475 from radish-bdd/cleanup/profile

Drop --profile option

Author: fliiiix

CHANGELOG.md

@@ -10,6 +10,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changes
 - Drop Python 3.6 and Python 3.7
+- Drop the `--profile` option, please use `--user-data`
 
 ## [v0.17.1]
 

docs/commandline.rst

@@ -121,28 +121,6 @@ the hooks defined in the terrain files.
 To see example code please consult :ref:`terrain <tutorial#terrain_and_hooks>`.
 
 
-Run - Profile
--------------
-
-Radish allows you to pass custom data to a Terrain hook code or to the Step implementations
-using the ``-p`` or ``--profile`` command line option. This can be used to
-customize your test runs as needed.
-
-The value specified to the ``-p`` / ``--profile`` command line option is made
-available in ``world.config.profile``. Please see :ref:`tutorial#world` for
-for an example.
-
-A common usage of ``profile`` s setting it to some environment value such as
-``stage`` or ``production``.
-
-.. code:: bash
-
-  radish SomeFeature.feature -p stage
-  radish SomeFeature.feature --profile stage
-
-Note: ``-p`` / ``--profile`` is being deprecated and will be removed in a future version of Radish. Please use ``-u`` / ``--user-data`` instead.  See :ref:`Arbitrary User Data <commandline#user_data>` for details.
-
-
 Run - Dry run
 -------------
 
@@ -557,7 +535,6 @@ Use the ``--help`` or ``-h`` option to show the following help screen:
              [--debug-steps]
              [-t | --with-traceback]
              [-m=<marker> | --marker=<marker>]
-             [-p=<profile> | --profile=<profile>]
              [-d | --dry-run]
              [-s=<scenarios> | --scenarios=<scenarios>]
              [--shuffle]
@@ -595,7 +572,6 @@ Use the ``--help`` or ``-h`` option to show the following help screen:
       --debug-steps                               debugs each step
       -t --with-traceback                         show the Exception traceback when a step fails
       -m=<marker> --marker=<marker>               specify the marker for this run [default: time.time()]
-      -p=<profile> --profile=<profile>            specify the profile which can be used in the step/hook implementation
       -b=<basedir> --basedir=<basedir>...         set base dir from where the step.py and terrain.py will be loaded. [default: $PWD/radish]
                                                   You can specify -b|--basedir multiple times. All files will be imported.
       -d --dry-run                                make dry run for the given feature files

docs/tutorial.rst

@@ -902,9 +902,6 @@ For example ``--bdd-xml`` argument can be accessed using
    # print basedir
    print(world.config.basedir)
 
-   # print profile
-   print(world.config.profile)
-
 
 Sometimes it's useful to have specific variables and functions available during
 a whole test run. These variables and functions can be added to the ``world``

radish/main.py

@@ -104,7 +104,6 @@ def main(args=None):
            [--debug-steps]
            [-t | --with-traceback]
            [-m=<marker> | --marker=<marker>]
-           [-p=<profile> | --profile=<profile>]
            [-d | --dry-run]
            [-s=<scenarios> | --scenarios=<scenarios>]
            [--shuffle]
@@ -125,7 +124,6 @@ def main(args=None):
     --debug-steps                               debugs each step
     -t --with-traceback                         show the Exception traceback when a step fails
     -m=<marker> --marker=<marker>               specify the marker for this run [default: time.time()]
-    -p=<profile> --profile=<profile>            specify the profile which can be used in the step/hook implementation
     -b=<basedir> --basedir=<basedir>...         set base dir from where the step.py and terrain.py will be loaded. [default: $PWD/radish]
                                                 You can specify -b|--basedir multiple times or split multiple paths with a colon (:) similar to $PATH. All files will be imported.
     -d --dry-run                                make dry run for the given feature files
@@ -168,13 +166,6 @@ def main(args=None):
 
     core = Core()
 
-    if world.config.profile:
-        msg = (
-            "Command line argument -p/--profile will be removed in a future version.  Please "
-            "use -u/--user-data instead."
-        )
-        warnings.warn(msg, DeprecationWarning, stacklevel=1)
-
     feature_files = []
     for given_feature in world.config.features:
         if not os.path.exists(given_feature):

tests/conftest.py

@@ -58,7 +58,6 @@ def mock_world_config():
         "--marker": "time.time()",
         "--no-ansi": False,
         "--no-line-jump": False,
-        "--profile": None,
         "--scenarios": None,
         "--shuffle": False,
         "--syslog": False,