fix: fix background on cursorline, better perf

Author: rachartier

README.md

@@ -61,7 +61,6 @@ require('tiny-inline-diagnostic').setup({
             factor = 0.27,
         },
         options = {
-            clear_on_insert = false,
             --- When overflow="wrap", when the message is too long, it is then displayed on multiple lines.
             overflow = "wrap",
 

lua/tiny-inline-diagnostic/diagnostic.lua

@@ -3,6 +3,8 @@ local M = {}
 local diagnostic_ns = vim.api.nvim_create_namespace("CursorDiagnostics")
 local utis = require("tiny-inline-diagnostic.utils")
 
+local previous_line_number = 0
+
 --- Function to get diagnostics for the current position in the code.
 -- @param diagnostics table - The table of diagnostics to check.
 -- @param curline number - The current line number.
@@ -154,17 +156,30 @@ end
 function M.set_diagnostic_autocmds(opts)
     vim.api.nvim_create_autocmd("LspAttach", {
         callback = function(event)
-            if opts.options.clear_on_insert then
-                vim.api.nvim_create_autocmd("InsertEnter", {
-                    buffer = event.buf,
-                    callback = function()
-                        vim.api.nvim_buf_clear_namespace(event.buf, diagnostic_ns, 0, -1)
-                    end,
-                    desc = "Clear diagnostics on insert enter",
-                })
-            end
+            -- if opts.options.clear_on_insert then
+            --     vim.api.nvim_create_autocmd("InsertEnter", {
+            --         buffer = event.buf,
+            --         callback = function()
+            --             pcall(vim.api.nvim_buf_clear_namespace, event.buf, diagnostic_ns, 0, -1)
+            --         end,
+            --         desc = "Clear diagnostics on insert enter",
+            --     })
+            -- end
+            --
+            vim.api.nvim_create_autocmd({ "CursorMoved" }, {
+                buffer = event.buf,
+                callback = function()
+                    local cursor_pos = vim.api.nvim_win_get_cursor(0)
+                    local curline = cursor_pos[1] - 1
+
+                    if curline == previous_line_number then
+                        return
+                    end
+                    pcall(vim.api.nvim_buf_clear_namespace, event.buf, diagnostic_ns, 0, -1)
+                end
+            })
 
-            vim.api.nvim_create_autocmd({ "CursorHold", "VimResized", "CursorMovedI" }, {
+            vim.api.nvim_create_autocmd({ "CursorMoved", "CursorMovedI", "VimResized" }, {
                 buffer = event.buf,
                 callback = function()
                     pcall(vim.api.nvim_buf_clear_namespace, event.buf, diagnostic_ns, 0, -1)
@@ -175,6 +190,7 @@ function M.set_diagnostic_autocmds(opts)
                         return
                     end
 
+                    previous_line_number = curline
                     local virt_texts = forge_virt_texts_from_diagnostic(opts, diag[1])
 
                     local virt_lines = {}

lua/tiny-inline-diagnostic/highlights.lua

@@ -24,9 +24,14 @@ function M.setup_highlights(blend, default_hi)
         info = get_hi(default_hi.info),
         hint = get_hi(default_hi.hint),
         arrow = get_hi(default_hi.arrow),
-        background = default_hi.background,
     }
 
+    if default_hi.background:sub(1, 1) == "#" then
+        colors.background = default_hi.background
+    else
+        colors.background = get_hi(default_hi.background).bg
+    end
+
     local factor = blend.factor
     local c = colors.background
 
@@ -42,12 +47,12 @@ function M.setup_highlights(blend, default_hi)
         TinyInlineDiagnosticVirtualTextWarn = { bg = blends.warn, fg = colors.warn.fg },
         TinyInlineDiagnosticVirtualTextInfo = { bg = blends.info, fg = colors.info.fg },
         TinyInlineDiagnosticVirtualTextHint = { bg = blends.hint, fg = colors.hint.fg },
-        TinyInlineDiagnosticVirtualTextArrow = colors.arrow,
+        TinyInlineDiagnosticVirtualTextArrow = { bg = colors.background, colors.arrow },
 
-        TinyInlineInvDiagnosticVirtualTextError = { fg = blends.error, bg = "None" },
-        TinyInlineInvDiagnosticVirtualTextWarn = { fg = blends.warn, bg = "None" },
-        TinyInlineInvDiagnosticVirtualTextInfo = { fg = blends.info, bg = "None" },
-        TinyInlineInvDiagnosticVirtualTextHint = { fg = blends.hint, bg = "None" },
+        TinyInlineInvDiagnosticVirtualTextError = { fg = blends.error, bg = colors.background },
+        TinyInlineInvDiagnosticVirtualTextWarn = { fg = blends.warn, bg = colors.background },
+        TinyInlineInvDiagnosticVirtualTextInfo = { fg = blends.info, bg = colors.background },
+        TinyInlineInvDiagnosticVirtualTextHint = { fg = blends.hint, bg = colors.background },
     }
 
     for name, opts in pairs(hi) do

lua/tiny-inline-diagnostic/init.lua

@@ -17,13 +17,13 @@ local default_config = {
         info = "DiagnosticInfo",
         hint = "DiagnosticHint",
         arrow = "NonText",
-        background = "None",
+        background = "CursorLine",
     },
     blend = {
         factor = 0.27,
     },
     options = {
-        clear_on_insert = false,
+        -- clear_on_insert = false,
         overflow = "wrap",
         break_line = {
             enabled = false,