Skip to content

Commit 589e0b5

Browse files
authored
Remove log level tests (#13723)
When debug logging is enabled, we log something at each log level to test if logs are emitted. I don't think this is particularly useful, but it's certainly annoying, because I constatnly need to filter out these logs when searching if any errors happened during tests.
1 parent 6eb1f87 commit 589e0b5

File tree

1 file changed

+1
-37
lines changed

1 file changed

+1
-37
lines changed

deps/rabbit/src/rabbit_prelaunch_logging.erl

Lines changed: 1 addition & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -527,12 +527,7 @@ configure_logger(Context) ->
527527
%% We can now install the new handlers. The function takes care of
528528
%% removing previously configured handlers (after installing the new
529529
%% ones to ensure we don't loose a message).
530-
ok = install_handlers(Handlers),
531-
532-
%% Let's log a message per log level (if debug logging is enabled). This
533-
%% is handy if the user wants to verify the configuration is what he
534-
%% expects.
535-
ok = maybe_log_test_messages(LogConfig3).
530+
ok = install_handlers(Handlers).
536531

537532
-spec get_log_configuration_from_app_env() -> log_config().
538533

@@ -1690,34 +1685,3 @@ get_less_severe_level(LevelA, LevelB) ->
16901685
lt -> LevelA;
16911686
_ -> LevelB
16921687
end.
1693-
1694-
-spec maybe_log_test_messages(log_config()) -> ok.
1695-
1696-
maybe_log_test_messages(
1697-
#{per_category := #{prelaunch := #{level := debug}}}) ->
1698-
log_test_messages();
1699-
maybe_log_test_messages(
1700-
#{global := #{level := debug}}) ->
1701-
log_test_messages();
1702-
maybe_log_test_messages(_) ->
1703-
ok.
1704-
1705-
-spec log_test_messages() -> ok.
1706-
1707-
log_test_messages() ->
1708-
?LOG_DEBUG("Logging: testing debug log level",
1709-
#{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),
1710-
?LOG_INFO("Logging: testing info log level",
1711-
#{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),
1712-
?LOG_NOTICE("Logging: testing notice log level",
1713-
#{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),
1714-
?LOG_WARNING("Logging: testing warning log level",
1715-
#{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),
1716-
?LOG_ERROR("Logging: testing error log level",
1717-
#{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),
1718-
?LOG_CRITICAL("Logging: testing critical log level",
1719-
#{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),
1720-
?LOG_ALERT("Logging: testing alert log level",
1721-
#{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),
1722-
?LOG_EMERGENCY("Logging: testing emergency log level",
1723-
#{domain => ?RMQLOG_DOMAIN_PRELAUNCH}).

0 commit comments

Comments
 (0)