Skip to content

Missing candidates when using separators #33

@luminouw

Description

@luminouw

Hello there,

When combining n words, the separators aren't used properly to go in between and some candidates are missing from the generated output.

Example :

With extra_combinations set to false, the following command returns 15 results including the abc string

# With extra_combinations set to false
bopscrk -m 1 -M 20 -n 3 -w a,b,c
[...]
a
b
c
ab
ac
ba
bc
ca
cb
abc
acb
bac
bca
cab
cba

Same command but with extra_combinations set to true and separators_chars=_ only to illustrate my issue, I get the following result with 39 words generated

a
b
c
ab
ac
ba
bc
ca
cb
abc
acb
bac
bca
cab
cba
a_
_a
b_
_b
c_
_c
b_a
ab_
_ba
a_b
c_a
ac_
_ca
a_c
ba_
_ab
c_b
bc_
_cb
b_c
ca_
_ac
cb_
_bc

Since the upper limit of number of words used for combinations (-n 3) and min/max length isn't an issue, I would expect to see words such as a_b_c in the generated list as the _ is used as a separator and as such would be used whenever n words are combined together.

Is this an expected behaviour or am I missing something ?

Thank you

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions