feat(core)!: remove r3_core::utils::ZeroInit

Author: yvt

src/r3/src/lib.rs

@@ -62,7 +62,7 @@ pub use r3_core::{bag, hunk, kernel, time};
 ///
 /// [1]: r3_core#stability
 pub mod utils {
-    pub use r3_core::utils::{Init, ZeroInit, Zeroable, ZeroableInOption};
+    pub use r3_core::utils::{Init, Zeroable, ZeroableInOption};
 }
 
 /// The prelude module.

src/r3_core/CHANGELOG.md

@@ -16,6 +16,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - `r3_core::utils::{Zeroable,ZeroableInOption}` (re-exported from `bytemuck ^1`)
 - Implement `Zeroable` on `r3_core::time::{Duration, Time}`
 
+### Removed
+
+- **Breaking:** `r3_core::utils::ZeroInit` (superseded by `Zeroable`)
+
 ## [0.1.4] - 2022-11-16
 
 ### Changed

src/r3_core/src/time/duration.rs

@@ -1,6 +1,6 @@
 use core::{fmt, ops};
 
-use crate::utils::{Init, ZeroInit, Zeroable};
+use crate::utils::{Init, Zeroable};
 
 /// Represents a signed time span used by the API surface of R3-OS.
 ///
@@ -16,10 +16,6 @@ impl Init for Duration {
     const INIT: Self = Self::ZERO;
 }
 
-// Safety: `Duration` is `repr(transparent)` and the only inner field is `i32`,
-//         which is `ZeroInit`
-unsafe impl ZeroInit for Duration {}
-
 impl Default for Duration {
     fn default() -> Self {
         Self::INIT

src/r3_core/src/time/time.rs

@@ -2,7 +2,7 @@ use core::{fmt, ops};
 
 use crate::{
     time::Duration,
-    utils::{Init, ZeroInit, Zeroable},
+    utils::{Init, Zeroable},
 };
 
 /// Represents a timestamp used by the API surface of R3-OS.
@@ -23,10 +23,6 @@ impl Init for Time {
     const INIT: Self = Self::ZERO;
 }
 
-// Safety: `Time` is `repr(transparent)` and the only inner field is `u64`,
-//         which is `ZeroInit`
-unsafe impl ZeroInit for Time {}
-
 impl Default for Time {
     fn default() -> Self {
         Self::INIT

src/r3_core/src/utils/mod.rs

@@ -74,11 +74,9 @@ mod init;
 pub mod mem;
 mod rawcell;
 pub(crate) mod refcell;
-mod zeroinit;
 pub use aligned_storage::*;
 pub use init::*;
 pub use rawcell::*;
-pub use zeroinit::*;
 
 pub use bytemuck::{Zeroable, ZeroableInOption};
 

src/r3_core/src/utils/rawcell.rs

@@ -1,6 +1,6 @@
 use core::cell::UnsafeCell;
 
-use crate::utils::{Init, ZeroInit, Zeroable};
+use crate::utils::{Init, Zeroable};
 
 /// Like `UnsafeCell`, but implements `Sync`.
 #[derive(Debug)]
@@ -28,7 +28,6 @@ impl<T: ?Sized> RawCell<T> {
 impl<T: Init> Init for RawCell<T> {
     const INIT: Self = RawCell::new(T::INIT);
 }
-unsafe impl<T: ZeroInit> ZeroInit for RawCell<T> {}
 // FIXME: Derive this when <https://github.com/Lokathor/bytemuck/pull/148> is
 //        merged
 unsafe impl<T: Zeroable> Zeroable for RawCell<T> {}

src/r3_core/src/utils/zeroinit.rs

@@ -56,7 +56,7 @@ mod rawcell;
 mod vec;
 pub use self::{aligned_storage::*, freeze::*, int::*, prio_bitmap::*, rawcell::*, vec::*};
 use r3_core::utils::{AllocError, Allocator, ConstAllocator};
-pub use r3_core::utils::{Init, ZeroInit, Zeroable};
+pub use r3_core::utils::{Init, Zeroable};
 pub(crate) mod panicking;
 
 /// A "type function" producing a type.