Merge branch '🚨-clippy' into 🦆

Author: yvt

.github/workflows/ci.yml

@@ -27,6 +27,10 @@ jobs:
           sudo apt-get update
           sudo apt-get install libusb-1.0-0-dev libudev-dev
 
+      - name: Allow `incomplete_features`
+        run: |
+          echo "RUSTFLAGS=-A incomplete_features" >> $GITHUB_ENV
+
       - name: Exclude crates
         run: |
           # Example crates will fail to compile unless an appropriate target
@@ -85,6 +89,10 @@ jobs:
           rustup target add thumbv6m-none-eabi thumbv7em-none-eabihf
           rustup target add armv7a-none-eabi
 
+      - name: Allow `incomplete_features`
+        run: |
+          echo "RUSTFLAGS=-A incomplete_features" >> $GITHUB_ENV
+
       - name: Build examples
         shell: bash
         run: |
@@ -129,6 +137,10 @@ jobs:
         if: "!startsWith(matrix.os, 'ubuntu-')"
         run: echo "testflags=--test-threads=1" >> $GITHUB_ENV
 
+      - name: Allow `incomplete_features`
+        run: |
+          echo "RUSTFLAGS=-A incomplete_features" >> $GITHUB_ENV
+
       - name: Exclude crates
         shell: bash
         run: |
@@ -171,6 +183,10 @@ jobs:
           sudo apt-get update
           sudo apt-get install libusb-1.0-0-dev libudev-dev
 
+      - name: Allow `incomplete_features`
+        run: |
+          echo "RUSTFLAGS=-A incomplete_features" >> $GITHUB_ENV
+
       - name: Convert feature list to Cargo parameter
         run: |
           features='${{ matrix.features }}'

Cargo.lock

@@ -60,5 +60,11 @@ git = "https://github.com/r3-os/rust-riscv-rt.git"
 branch = "refresh/0.8"
 version = "0.6.2"
 
+[patch.crates-io.memoffset]
+# FIXME: Waiting for the fix for false clippy warnings
+# <https://github.com/Gilnaa/memoffset/pull/64> to be published to crates.io
+git = "https://github.com/Gilnaa/memoffset.git"
+rev = "2a74b62c26724ff9c67e4e3ad05378a1af53f195"
+
 [profile.release]
 debug = true

Cargo.toml

@@ -5,8 +5,7 @@
 #![feature(const_mut_refs)]
 #![deny(unsafe_op_in_unsafe_fn)]
 use r3::{
-    kernel::{prelude::*, traits, StaticTask},
-    prelude::*,
+    kernel::{prelude::*, StaticTask},
     sync::StaticMutex,
 };
 
@@ -15,9 +14,9 @@ r3_port_std::use_port!(unsafe struct SystemTraits);
 
 #[derive(Debug)]
 struct Objects {
-    task1: StaticTask<System>,
+    _task1: StaticTask<System>,
     task2: StaticTask<System>,
-    mutex1: StaticMutex<System, u32>,
+    _mutex1: StaticMutex<System, u32>,
 }
 
 const COTTAGE: Objects = r3_kernel::build!(SystemTraits, configure_app => Objects);
@@ -35,9 +34,9 @@ const fn configure_app(b: &mut r3_kernel::Cfg<'_, SystemTraits>) -> Objects {
     let mutex1 = StaticMutex::define().finish(b);
 
     Objects {
-        task1,
+        _task1: task1,
         task2,
-        mutex1,
+        _mutex1: mutex1,
     }
 }
 

examples/basic/src/main.rs

@@ -35,9 +35,9 @@ impl port::SysTickOptions for SystemTraits {
 
 #[derive(Debug)]
 struct Objects {
-    task1: StaticTask<System>,
+    _task1: StaticTask<System>,
     task2: StaticTask<System>,
-    mutex1: StaticMutex<System, u32>,
+    _mutex1: StaticMutex<System, u32>,
 }
 
 const COTTAGE: Objects = r3_kernel::build!(SystemTraits, configure_app => Objects);
@@ -65,9 +65,9 @@ const fn configure_app(b: &mut r3_kernel::Cfg<SystemTraits>) -> Objects {
     let mutex1 = StaticMutex::define().finish(b);
 
     Objects {
-        task1,
+        _task1: task1,
         task2,
-        mutex1,
+        _mutex1: mutex1,
     }
 }
 

examples/basic_nucleo_f401re/src/main.rs

@@ -45,6 +45,8 @@
 //! [pdf]: http://infocenter.arm.com/help/topic/com.arm.doc.dui0471e/DUI0471E_developing_for_arm_processors.pdf
 
 #![deny(missing_docs)]
+#![allow(clippy::missing_safety_doc)]
+#![allow(clippy::result_unit_err)]
 #![no_std]
 
 #[macro_use]

src/arm_semihosting/src/lib.rs

@@ -766,6 +766,7 @@ macro_rules! impl_unzip_bind_for_tuples {
 
             fn unzip(self) -> Self::Target {
                 #[allow(unused_unsafe)] // for `Bind<'_, _, ()>`
+                #[allow(clippy::unused_unit)] // for `Bind<'_, _, ()>`
                 unsafe {
                     let divide = DivideBind::new(self);
                     let hunk = divide.original_hunk();
@@ -900,10 +901,12 @@ impl CfgBindRegistry {
                 // [tag:bind_finalization_immediate_panic] The errors are
                 // reported by panicking immediately for now
                 match e {
-                    sorter::SorterError::BindCycle { bind_is: _ } => {
+                    sorter::SorterError::BindCycle { bind_is } => {
+                        let _ = bind_is; // TODO: Display the bindings' names
                         panic!("the binding initialization order contains a cycle");
                     }
-                    sorter::SorterError::ConflictingIndefiniteBorrow { bind_i: _ } => {
+                    sorter::SorterError::ConflictingIndefiniteBorrow { bind_i } => {
+                        let _ = bind_i; // TODO: Display the binding's name
                         panic!("conflicting indefinite borrows");
                     }
                 }
@@ -1734,6 +1737,7 @@ macro_rules! impl_binder_on_tuples {
                 let _ = ctx;
             }
 
+            #[allow(clippy::unused_unit)]
             fn into_runtime_binder(self) -> Self::Runtime {
                 ( $( self.$I.into_runtime_binder(), )* )
             }
@@ -1747,6 +1751,7 @@ macro_rules! impl_binder_on_tuples {
 
             #[allow(unused_unsafe)]
             #[allow(unused_variables)]
+            #[allow(clippy::unused_unit)]
             #[inline]
             unsafe fn materialize<'call>(self) -> Self::Target<'call> {
                 unsafe {

src/r3_core/src/bind.rs

@@ -298,6 +298,7 @@ impl<System: raw::KernelBase + cfg::KernelStatic, T: ?Sized> Hunk<System, T> {
 
     /// Get a reference to the hunk's contents.
     #[inline]
+    #[allow(clippy::should_implement_trait)]
     pub fn as_ref<'a>(this: Self) -> &'a T
     where
         T: 'a,

src/r3_core/src/hunk.rs

@@ -161,7 +161,6 @@ impl<System: raw::KernelEventGroup> EventGroupDefiner<System> {
                 initial_bits: initial,
                 ..self.inner
             },
-            ..self
         }
     }
 
@@ -172,10 +171,9 @@ impl<System: raw::KernelEventGroup> EventGroupDefiner<System> {
     pub const fn queue_order(self, queue_order: raw::QueueOrder) -> Self {
         Self {
             inner: raw_cfg::EventGroupDescriptor {
-                queue_order: queue_order,
+                queue_order,
                 ..self.inner
             },
-            ..self
         }
     }