Fix MssqlRowMetadata.toArray(T[]) implementation.

toArray(T[]) now reuses the given array or constructs a new one if the array size doesn't match the collection size.

[resolves #200]

Signed-off-by: Mark Paluch <mpaluch@vmware.com>

Author: mp911de

src/main/java/io/r2dbc/mssql/MssqlRowMetadata.java

@@ -23,6 +23,7 @@
 import io.r2dbc.spi.RowMetadata;
 import reactor.util.annotation.Nullable;
 
+import java.lang.reflect.Array;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.HashMap;
@@ -163,7 +164,16 @@ public String next() {
     @Override
     @SuppressWarnings("unchecked")
     public <T> T[] toArray(T[] a) {
-        return (T[]) toArray();
+
+        if (a.length < size()) {
+            a = (T[]) Array.newInstance(a.getClass().getComponentType(), size());
+        }
+
+        for (int i = 0; i < size(); i++) {
+            a[i] = (T) this.getColumn(i).getName();
+        }
+
+        return a;
     }
 
     @Override

src/test/java/io/r2dbc/mssql/MssqlRowMetadataUnitTests.java

@@ -116,6 +116,7 @@ void shouldReturnMetadataForAllColumns() {
     }
 
     @Test
+    @SuppressWarnings("cast")
     void shouldReturnOrderedColumnNames() {
 
         Column c1 = new Column(0, "one", this.integer, null);
@@ -135,6 +136,8 @@ void shouldReturnOrderedColumnNames() {
 
         assertThat(rowMetadata.getColumnNames().contains("One")).isTrue();
         assertThat(rowMetadata.getColumnNames().contains("óne")).isFalse();
+        assertThat(rowMetadata.getColumnNames().toArray()).contains("one", "two");
+        assertThat((String[]) rowMetadata.getColumnNames().toArray(new String[0])).contains("one", "two");
     }
 
     @Test