Skip to content

Commit f00c984

Browse files
authored
Fix the issue where timeout failure is not counted as failure in statistics. (#96)
1 parent 4387546 commit f00c984

7 files changed

+4
-10
lines changed

src/ping_result_processors/ping_result_processor_console_logger.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,10 @@ impl PingResultProcessorConsoleLogger {
7171
}
7272

7373
self.ping_count += 1;
74-
match ping_result.error() {
75-
Some(_) => self.failure_count += 1,
76-
None => self.success_count += 1,
74+
if ping_result.is_succeeded() {
75+
self.success_count += 1;
76+
} else {
77+
self.failure_count += 1;
7778
}
7879

7980
if let Some(warning) = ping_result.warning() {
@@ -134,7 +135,6 @@ impl PingResultProcessor for PingResultProcessorConsoleLogger {
134135
fn name(&self) -> &'static str {
135136
"ConsoleLogger"
136137
}
137-
138138
fn config(&self) -> &PingResultProcessorCommonConfig {
139139
self.common_config.as_ref()
140140
}

src/ping_result_processors/ping_result_processor_csv_logger.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ impl PingResultProcessor for PingResultProcessorCsvLogger {
2727
fn name(&self) -> &'static str {
2828
"CsvLogger"
2929
}
30-
3130
fn config(&self) -> &PingResultProcessorCommonConfig {
3231
self.common_config.as_ref()
3332
}

src/ping_result_processors/ping_result_processor_json_logger.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ impl PingResultProcessor for PingResultProcessorJsonLogger {
4040
fn name(&self) -> &'static str {
4141
"JsonLogger"
4242
}
43-
4443
fn config(&self) -> &PingResultProcessorCommonConfig {
4544
self.common_config.as_ref()
4645
}

src/ping_result_processors/ping_result_processor_latency_bucket_logger.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ impl PingResultProcessor for PingResultProcessorLatencyBucketLogger {
8282
fn name(&self) -> &'static str {
8383
"LatencyBucketLogger"
8484
}
85-
8685
fn config(&self) -> &PingResultProcessorCommonConfig {
8786
self.common_config.as_ref()
8887
}

src/ping_result_processors/ping_result_processor_latency_scatter_logger.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ impl PingResultProcessor for PingResultProcessorLatencyScatterLogger {
5757
fn name(&self) -> &'static str {
5858
"LatencyScatterLogger"
5959
}
60-
6160
fn config(&self) -> &PingResultProcessorCommonConfig {
6261
self.common_config.as_ref()
6362
}

src/ping_result_processors/ping_result_processor_result_scatter_logger.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ impl PingResultProcessor for PingResultProcessorResultScatterLogger {
4747
fn name(&self) -> &'static str {
4848
"ResultScatterLogger"
4949
}
50-
5150
fn config(&self) -> &PingResultProcessorCommonConfig {
5251
self.common_config.as_ref()
5352
}

src/ping_result_processors/ping_result_processor_text_logger.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ impl PingResultProcessor for PingResultProcessorTextLogger {
2222
fn name(&self) -> &'static str {
2323
"TextLogger"
2424
}
25-
2625
fn config(&self) -> &PingResultProcessorCommonConfig {
2726
self.common_config.as_ref()
2827
}

0 commit comments

Comments
 (0)