Skip to content

Commit 90d9c37

Browse files
authored
Fix sub-millisecond time always being 0. (#161)
Issue #158.
1 parent 9ba561a commit 90d9c37

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/ping_runners/ping_result.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ impl PingResult {
140140
source_port: self.source().port(),
141141
is_warmup: self.is_warmup(),
142142
is_succeeded: self.is_succeeded(),
143-
rtt_in_ms: self.round_trip_time().as_millis() as f64,
143+
rtt_in_ms: self.round_trip_time().as_micros() as f64 / 1000.0,
144144
is_timed_out: self.is_timed_out(),
145145
preparation_error,
146146
ping_error,

tests/ping_runner_core_tests.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,15 @@ fn ping_with_rnp_core_should_work() {
2727
let results = actual_ping_results.lock().unwrap();
2828
assert_eq!(
2929
vec![
30-
MockPingClientResult::Success(Duration::from_millis(10)),
30+
MockPingClientResult::Success(Duration::from_micros(12345)),
3131
MockPingClientResult::Timeout,
3232
MockPingClientResult::PreparationFailed,
33-
MockPingClientResult::Success(Duration::from_millis(10)),
33+
MockPingClientResult::Success(Duration::from_micros(12345)),
3434
MockPingClientResult::Timeout,
3535
MockPingClientResult::PreparationFailed,
3636
MockPingClientResult::PingFailed,
37-
MockPingClientResult::AppHandshakeFailed(Duration::from_millis(20)),
38-
MockPingClientResult::DisconnectFailed(Duration::from_millis(30)),
37+
MockPingClientResult::AppHandshakeFailed(Duration::from_micros(23456)),
38+
MockPingClientResult::DisconnectFailed(Duration::from_micros(34567)),
3939
],
4040
*results
4141
);
@@ -153,12 +153,12 @@ fn create_mock_rnp_config(
153153
Some(Box::new(MockPingClient::new(
154154
config,
155155
vec![
156-
MockPingClientResult::Success(Duration::from_millis(10)),
156+
MockPingClientResult::Success(Duration::from_micros(12345)),
157157
MockPingClientResult::Timeout,
158158
MockPingClientResult::PreparationFailed,
159159
MockPingClientResult::PingFailed,
160-
MockPingClientResult::AppHandshakeFailed(Duration::from_millis(20)),
161-
MockPingClientResult::DisconnectFailed(Duration::from_millis(30)),
160+
MockPingClientResult::AppHandshakeFailed(Duration::from_micros(23456)),
161+
MockPingClientResult::DisconnectFailed(Duration::from_micros(34567)),
162162
],
163163
)))
164164
}),

0 commit comments

Comments
 (0)