Skip to content

Commit b790ca5

Browse files
committed
Prepare for releaze
1 parent 1aa3207 commit b790ca5

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

NEWS

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
0.8.6
2+
- Update gifski crate to 0.8.6
23
- save_gif() now properly closes graphics device when expr errors
3-
- safer C code to prevent segfaults on write errors
4+
- More rubust C code to prevent segfaults on write errors
5+
- File paths are now converted to UTF-8 as described in gifski.h

R/gifski.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ gifski <- function(png_files, gif_file = 'animation.gif', width = 800, height =
3737
delay <- as.integer(delay * 100)
3838
loop <- as.logical(loop)
3939
progress <- as.logical(progress)
40-
.Call(R_png_to_gif, png_files, gif_file, width, height, delay, loop, progress)
40+
.Call(R_png_to_gif, enc2utf8(png_files), enc2utf8(gif_file), width, height, delay, loop, progress)
4141
}
4242

4343
#' @export

src/wrapper.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010

1111
/* data to pass to encoder thread */
1212
typedef struct {
13-
const char * path;
13+
const char *path;
1414
GifskiError err;
15-
gifski * g;
15+
gifski *g;
1616
} gifski_encoder_thread_info;
1717

1818
/* gifski_write() blocks until main thread calls gifski_end_adding_frames() */
@@ -34,7 +34,7 @@ SEXP R_png_to_gif(SEXP png_files, SEXP gif_file, SEXP width, SEXP height, SEXP d
3434
settings.once = !Rf_asLogical(loop);
3535

3636
/* init in main thread */
37-
gifski * g = gifski_new(&settings);
37+
gifski *g = gifski_new(&settings);
3838

3939
/* create encoder thread; TODO: maybe we can use multiple encoder threads? */
4040
pthread_t encoder_thread;

0 commit comments

Comments
 (0)