Skip to content

Commit 163c3f2

Browse files
florisvdhjennybc
andauthored
submit_cran(): explain relation to usethis::use_release_issue() (#2531)
* submit_cran(): explain relation to usethis::use_release_issue() * See r-lib/usethis#1877. * Tweak wording and modernize a few things --------- Co-authored-by: Jenny Bryan <jenny.f.bryan@gmail.com>
1 parent 2008535 commit 163c3f2

File tree

3 files changed

+40
-20
lines changed

3 files changed

+40
-20
lines changed

R/release.R

Lines changed: 22 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,10 @@
44
#'
55
#' The package release process will:
66
#'
7-
#' \itemize{
8-
#' \item Confirm that the package passes `R CMD check` on relevant platforms
9-
#' \item Confirm that important files are up-to-date
10-
#' \item Build the package
11-
#' \item Submit the package to CRAN, using comments in "cran-comments.md"
12-
#' }
7+
#' * Confirm that the package passes `R CMD check` on relevant platforms
8+
#' * Confirm that important files are up-to-date
9+
#' * Build the package
10+
#' * Submit the package to CRAN, using comments in "cran-comments.md"
1311
#'
1412
#' You can add arbitrary extra questions by defining an (un-exported) function
1513
#' called `release_questions()` that returns a character vector
@@ -203,14 +201,26 @@ cran_comments <- function(pkg = ".", call = parent.frame()) {
203201

204202
cran_submission_url <- "https://xmpalantir.wu.ac.at/cransubmit/index2.php"
205203

206-
#' Submit a package to CRAN.
204+
#' Submit a package to CRAN
207205
#'
208-
#' This uses the new CRAN web-form submission process. After submission, you
209-
#' will receive an email asking you to confirm submission - this is used
210-
#' to check that the package is submitted by the maintainer.
206+
#' @description
207+
208+
#' This submits your package to CRAN using the web-form submission process.
209+
#' After submission, you will receive an email asking you to confirm submission
210+
#' - this is used to check that the package is submitted by the maintainer.
211+
#'
212+
#' You may prefer to use `submit_cran()` indirectly, by calling [release()]
213+
#' instead. `release()` performs many checks verifying that your package is
214+
#' indeed ready for CRAN, before eventually asking for your confirmation that
215+
#' you'd like to submit it to CRAN (which it does by calling `submit_cran()`).
211216
#'
212-
#' It's recommended that you use [release()] rather than this
213-
#' function as it performs more checks prior to submission.
217+
#' Whether to use `release()` or `submit_cran()` depends on the rest of your
218+
#' development process. If you want to be super cautious, use `release()`, even
219+
#' though it may be redundant with other checks you have performed. On the other
220+
#' hand, if you have many other checks in place (such as automated checks via
221+
#' GitHub Actions and the task list generated by
222+
#' [usethis::use_release_issue()]), it makes sense to use `submit_cran()`
223+
#' directly.
214224
#'
215225
#' @template devtools
216226
#' @inheritParams release

man/release.Rd

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/submit_cran.Rd

Lines changed: 18 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)