remove all source and sink setup abstracts (#784)

Author: tim-quix

docs/connectors/sinks/README.md

@@ -130,6 +130,6 @@ Assuming a given connector is set up to utilize them, there are two callbacks th
 be set for when a client connects/authenticates successfully or not, named 
 `on_client_connect_success` and `on_client_connect_failure`, respectfully.
 
-Though having a `setup` method is required, it is not guaranteed that it is implemented or
-utilized fully with `community` sinks; you can inspect a given Sink's `setup` method 
+Though implementing an applicable `setup` method is strongly encouraged, it is not an
+enforced guarantee with `community` sinks; you can inspect a given Sink's `setup` method 
 to confirm whether it tests the client connection there (and that the callbacks are then applicable).

quixstreams/sinks/base/sink.py

@@ -80,7 +80,6 @@ def add(
         on flush().
         """
 
-    @abc.abstractmethod
     def setup(self):
         """
         When applicable, set up the client here along with any validation to affirm a

quixstreams/sources/base/source.py

@@ -122,6 +122,13 @@ def configure(self, topic: Topic, producer: RowProducer, **kwargs) -> None:
         self._producer = producer
         self._producer_topic = topic
 
+    def setup(self):
+        """
+        When applicable, set up the client here along with any validation to affirm a
+        valid/successful authentication/connection.
+        """
+        return
+
     @property
     def producer(self) -> RowProducer:
         if self._producer is None:
@@ -161,13 +168,6 @@ def default_topic(self) -> Topic:
         Note: if the default topic is used, the Application will prefix its name with "source__".
         """
 
-    @abstractmethod
-    def setup(self):
-        """
-        When applicable, set up the client here along with any validation to affirm a
-        valid/successful authentication/connection.
-        """
-
 
 class Source(BaseSource):
     """
@@ -256,13 +256,6 @@ def running(self) -> bool:
         """
         return self._running
 
-    def setup(self):
-        """
-        Though implemented for the sake of making simple sources easier to use,
-        it is still recommended to override this when using a client-based pattern.
-        """
-        return
-
     def cleanup(self, failed: bool) -> None:
         """
         This method is triggered once the `run` method completes.

tests/test_quixstreams/test_checkpointing.py

@@ -66,15 +66,11 @@ def write(self, batch: SinkBatch):
             retry_after=999, topic=batch.topic, partition=batch.partition
         )
 
-    def setup(self): ...
-
 
 class FailingSink(BatchingSink):
     def write(self, batch: SinkBatch):
         raise ValueError("Sink write failed")
 
-    def setup(self): ...
-
 
 @pytest.mark.parametrize("store_type", SUPPORTED_STORES, indirect=True)
 class TestCheckpoint:

tests/utils.py

@@ -111,9 +111,6 @@ def __init__(self):
         super().__init__()
         self._results = []
 
-    def setup(self):
-        return
-
     def write(self, batch: SinkBatch):
         for item in batch:
             self._results.append(item)
@@ -161,9 +158,6 @@ def _produce(self):
             msg = self.serialize(key=self.key, value=value)
             self.produce(value=msg.value, key=msg.key)
 
-    def setup(self):
-        return
-
     def cleanup(self, failed):
         if "cleanup" in self.error_in:
             self.error("test cleanup error")