Create pre-commit hook that checks Conda requirements (#596)

* Create pre-commit hook that checks Conda requirements

* Fix pyiceberg requirements and add license

Author: gwaramadze

.pre-commit-config.yaml

@@ -4,3 +4,10 @@ repos:
     hooks:
       - id: ruff
       - id: ruff-format
+  - repo: local
+    hooks:
+      - id: conda-requirements
+        name: conda-requirements
+        entry: python conda/requirements.py
+        language: python
+        files: ^(requirements\.txt|pyproject\.toml)$

LICENSES/LICENSE.pyiceberg

@@ -0,0 +1,235 @@
+
+                                 Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+      "License" shall mean the terms and conditions for use, reproduction,
+      and distribution as defined by Sections 1 through 9 of this document.
+
+      "Licensor" shall mean the copyright owner or entity authorized by
+      the copyright owner that is granting the License.
+
+      "Legal Entity" shall mean the union of the acting entity and all
+      other entities that control, are controlled by, or are under common
+      control with that entity. For the purposes of this definition,
+      "control" means (i) the power, direct or indirect, to cause the
+      direction or management of such entity, whether by contract or
+      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      outstanding shares, or (iii) beneficial ownership of such entity.
+
+      "You" (or "Your") shall mean an individual or Legal Entity
+      exercising permissions granted by this License.
+
+      "Source" form shall mean the preferred form for making modifications,
+      including but not limited to software source code, documentation
+      source, and configuration files.
+
+      "Object" form shall mean any form resulting from mechanical
+      transformation or translation of a Source form, including but
+      not limited to compiled object code, generated documentation,
+      and conversions to other media types.
+
+      "Work" shall mean the work of authorship, whether in Source or
+      Object form, made available under the License, as indicated by a
+      copyright notice that is included in or attached to the work
+      (an example is provided in the Appendix below).
+
+      "Derivative Works" shall mean any work, whether in Source or Object
+      form, that is based on (or derived from) the Work and for which the
+      editorial revisions, annotations, elaborations, or other modifications
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and Derivative Works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control systems,
+      and issue tracking systems that are managed by, or on behalf of, the
+      Licensor for the purpose of discussing and improving the Work, but
+      excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
+
+      "Contributor" shall mean Licensor and any individual or Legal Entity
+      on behalf of whom a Contribution has been received by Licensor and
+      subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      copyright license to reproduce, prepare Derivative Works of,
+      publicly display, publicly perform, sublicense, and distribute the
+      Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
+
+   4. Redistribution. You may reproduce and distribute copies of the
+      Work or Derivative Works thereof in any medium, with or without
+      modifications, and in Source or Object form, provided that You
+      meet the following conditions:
+
+      (a) You must give any other recipients of the Work or
+          Derivative Works a copy of this License; and
+
+      (b) You must cause any modified files to carry prominent notices
+          stating that You changed the files; and
+
+      (c) You must retain, in the Source form of any Derivative Works
+          that You distribute, all copyright, patent, trademark, and
+          attribution notices from the Source form of the Work,
+          excluding those notices that do not pertain to any part of
+          the Derivative Works; and
+
+      (d) If the Work includes a "NOTICE" text file as part of its
+          distribution, then any Derivative Works that You distribute must
+          include a readable copy of the attribution notices contained
+          within such NOTICE file, excluding those notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright statement to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+      any Contribution intentionally submitted for inclusion in the Work
+      by You to the Licensor shall be under the terms and conditions of
+      this License, without any additional terms or conditions.
+      Notwithstanding the above, nothing herein shall supersede or modify
+      the terms of any separate license agreement you may have executed
+      with Licensor regarding such Contributions.
+
+   6. Trademarks. This License does not grant permission to use the trade
+      names, trademarks, service marks, or product names of the Licensor,
+      except as required for reasonable and customary use in describing the
+      origin of the Work and reproducing the content of the NOTICE file.
+
+   7. Disclaimer of Warranty. Unless required by applicable law or
+      agreed to in writing, Licensor provides the Work (and each
+      Contributor provides its Contributions) on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+      implied, including, without limitation, any warranties or conditions
+      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+      PARTICULAR PURPOSE. You are solely responsible for determining the
+      appropriateness of using or redistributing the Work and assume any
+      risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+      whether in tort (including negligence), contract, or otherwise,
+      unless required by applicable law (such as deliberate and grossly
+      negligent acts) or agreed to in writing, shall any Contributor be
+      liable to You for damages, including any direct, indirect, special,
+      incidental, or consequential damages of any character arising as a
+      result of this License or out of the use or inability to use the
+      Work (including but not limited to damages for loss of goodwill,
+      work stoppage, computer failure or malfunction, or any and all
+      other commercial damages or losses), even if such Contributor
+      has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Additional Liability. While redistributing
+      the Work or Derivative Works thereof, You may choose to offer,
+      and charge a fee for, acceptance of support, warranty, indemnity,
+      or other liability obligations and/or rights consistent with this
+      License. However, in accepting such obligations, You may act only
+      on Your own behalf and on Your sole responsibility, not on behalf
+      of any other Contributor, and only if You agree to indemnify,
+      defend, and hold each Contributor harmless for any liability
+      incurred by, or claims asserted against, such Contributor by reason
+      of your accepting any such warranty or additional liability.
+
+   END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright [yyyy] [name of copyright owner]
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+
+--------------------------------------------------------------------------------
+
+This product includes code from Apache Avro.
+
+* Code for initializing the Avro (de)compression codecs
+* The Binary decoder for reading in an Avro byte stream
+
+Copyright: 2014-2022 The Apache Software Foundation.
+Home page: https://avro.apache.org/
+License: https://www.apache.org/licenses/LICENSE-2.0
+
+--------------------------------------------------------------------------------
+
+This product includes code from Apache Thrift.
+
+* Uses the fb303.thrift file that's part of Hive's thrift service in vendor/fb303/
+
+Copyright: 2006-2022 The Apache Software Foundation.
+Home page: https://thrift.apache.org/
+License: https://www.apache.org/licenses/LICENSE-2.0
+
+--------------------------------------------------------------------------------
+
+This product includes code from Apache Hive.
+
+* Uses hive_metastore.thrift to generate the Hive Metastore client in vendor/hive_metastore/
+
+Copyright: 2008-2022 The Apache Software Foundation.
+Home page: https://hive.apache.org/
+License: https://www.apache.org/licenses/LICENSE-2.0
+
+--------------------------------------------------------------------------------

conda/post-link.sh

@@ -3,4 +3,5 @@
 $PREFIX/bin/pip install \
 'rocksdict>=0.3,<0.4' \
 'protobuf>=5.27.2,<6.0' \
-'influxdb3-python>=0.7,<1.0'
+'influxdb3-python>=0.7,<1.0' \
+'pyiceberg[pyarrow,glue]>=0.7,<0.8'

conda/requirements.py

@@ -0,0 +1,87 @@
+import re
+import sys
+from pathlib import Path
+
+PYPI_OPTIONAL_GROUP = re.compile(r"all\s*=\s*\[\n(.*?)\n\]", re.DOTALL)
+PYPI_MAIN_REQUIREMENTS = re.compile(r"([\w\[\],-]+)([><=,.\d]*)?")
+PYPI_OPTIONAL_REQUIREMENTS = re.compile(r"([\w\[\],-]+)([><=,.\d]*)\",?")
+
+CONDA_META_GROUP = re.compile(r"run:\n(.+)\ntest", re.DOTALL)
+CONDA_META_REQUIREMENTS = re.compile(r"\s{4}- ([\w-]+) ([><=,.\d]*)?")
+CONDA_POST_LINK_REQUIREMENTS = re.compile(r"'([\w\[\],-]+)([><=,.\d]*)?")
+
+PYPI_TO_CONDA_NAME_MAPPING = {
+    "confluent-kafka": "python-confluent-kafka",
+}
+
+
+def get_pypi_main_requirements(filename):
+    text = Path(filename).read_text()
+    result = PYPI_MAIN_REQUIREMENTS.findall(text)
+    return result
+
+
+def get_pypi_optional_requirements(filename):
+    text = Path(filename).read_text()
+    text = PYPI_OPTIONAL_GROUP.search(text).group(1)
+    result = PYPI_OPTIONAL_REQUIREMENTS.findall(text)
+    return result
+
+
+def get_conda_meta_requirements(filename):
+    text = Path(filename).read_text()
+    text = CONDA_META_GROUP.search(text).group(1)
+    result = CONDA_META_REQUIREMENTS.findall(text)
+    return result
+
+
+def get_conda_post_link_requirements(filename):
+    text = Path(filename).read_text()
+    result = CONDA_POST_LINK_REQUIREMENTS.findall(text)
+    return result
+
+
+if __name__ == "__main__":
+    pypi_requirements = dict(
+        get_pypi_main_requirements("requirements.txt")
+        + get_pypi_optional_requirements("pyproject.toml")
+    )
+    conda_requirements = dict(
+        get_conda_meta_requirements("conda/meta.yaml")
+        + get_conda_post_link_requirements("conda/post-link.sh")
+    )
+
+    # Conda specifies Python version alongside other requirements
+    del conda_requirements["python"]
+
+    # Same packages may have different names in PyPI and Conda
+    for pypi_name, conda_name in PYPI_TO_CONDA_NAME_MAPPING.items():
+        pypi_requirements[conda_name] = pypi_requirements[pypi_name]
+        del pypi_requirements[pypi_name]
+
+    if pypi_requirements != conda_requirements:
+        missing_requirements = []
+        differing_requirements = []
+        for lib, pypi_version in pypi_requirements.items():
+            if lib in conda_requirements:
+                conda_version = conda_requirements[lib]
+                if conda_version != pypi_version:
+                    differing_requirements.append((lib, pypi_version, conda_version))
+            else:
+                missing_requirements.append(lib)
+
+        print("PyPI and Conda requirements do not match.\n")
+
+        if differing_requirements:
+            print("Differing requirements:")
+            for lib, pypi_version, conda_version in differing_requirements:
+                print(f"- {lib}")
+                print(f"    PyPI version: {pypi_version}")
+                print(f"    Conda version: {conda_version}")
+            print()
+
+        if missing_requirements:
+            formatted_missing_requirements = ", ".join(missing_requirements)
+            print(f"Missing in Conda requirements: {formatted_missing_requirements}.")
+
+        sys.exit(1)

pyproject.toml

@@ -31,17 +31,14 @@ all = [
     "fastavro>=1.8,<2.0",
     "protobuf>=5.27.2,<6.0",
     "influxdb3-python>=0.7,<1.0",
-    "pyarrow",
-    "pyiceberg",
-    "boto3",
-    "mypy_boto3_glue",
+    "pyiceberg[pyarrow,glue]>=0.7,<0.8",
 ]
 
 avro = ["fastavro>=1.8,<2.0"]
 protobuf = ["protobuf>=5.27.2,<6.0"]
 influxdb3 = ["influxdb3-python>=0.7,<1.0"]
-iceberg = ["pyarrow", "pyiceberg"]
-iceberg_aws = ["pyarrow", "pyiceberg", "boto3", "mypy_boto3_glue"]
+iceberg = ["pyiceberg[pyarrow]>=0.7,<0.8"]
+iceberg_aws = ["pyiceberg[pyarrow,glue]>=0.7,<0.8"]
 
 [tool.setuptools.packages.find]
 include = ["quixstreams*"]

requirements.txt

@@ -1,6 +1,6 @@
 confluent-kafka>=2.2,<2.5
 requests>=2.32
-rocksdict>=0.3, <0.4
+rocksdict>=0.3,<0.4
 typing_extensions>=4.8
 orjson>=3.9,<4
 pydantic>=2.7,<2.10

tests/requirements.txt

@@ -5,5 +5,4 @@ docker>=7.1.0 # Required to use requests>=2.32
 fastavro>=1.8,<2.0
 protobuf>=5.27.2
 influxdb3-python>=0.7.0,<1.0
-pyarrow
-pyiceberg
+pyiceberg[pyarrow,glue]>=0.7,<0.8