Atlas does not raise an error if an input filename is not unique

[grdw]

Related discussion: quintel/etmodel#2324 (comment)

---

It would be great if Atlas were to know if all the filenames of inputs are unique.

[antw]

Atlas does not raise an error if an input filename is not unique

It should do.

Atlas::Input.new(key: 'unique', query: '0.0').save
# => true

Atlas::Input.new(key: 'unique', query: '0.0').save
# => Atlas::DuplicateKeyError: Duplicate key found: unique
# => from atlas/lib/atlas/active_document/manager.rb:95:in `write'

[grdw]

That's odd. I can reproduce the error with the code you provided but ETEngine never throws an error once you use two inputs with the same name. I'll investigate this further when I've a bit more time.

[ploh]

Atlas does not raise an error if an input filename is not unique

It should do.

But that only checks the uniqueness when writing, not when reading. And since etsource files are often written by hand, this seems to not be enough.

What about adding raising an exception if a key occurs twice here?

[antw]

But that only checks the uniqueness when writing, not when reading. And since etsource files are often written by hand, this seems to not be enough.

I'm not sure checking that is really Atlas' responsibility; as far as it is concerned, you create documents by calling new then save. I have mixed feeling about adding a check to Atlas, since it's not possible to create a duplicate document using Atlas alone.

I think my view is:

• If the error can happen by using Atlas, then Atlas should guard against it. Examples include presets validating that share groups sum to 100 and datasets asserting the presence of the interconnector capacity.

• If the error cannot occur through Atlas, then the test should exist in the ETSource specs, so that the user can be warned before commiting their (hand-made) changes.

What I would support is being able to do something validates :key, uniqueness: true so that a duplicate document would still be caught when calling save (and automatically by the ETSource validate_documents_spec.rb tests).

This isn't very high-priority IMO.

[ploh]

If the error cannot occur through Atlas, then the test should exist in the ETSource specs, so that the user can be warned before commiting their (hand-made) changes.

What I would support is being able to do something validates :key, uniqueness: true so that a duplicate document would still be caught when calling save (and automatically by the ETSource validate_documents_spec.rb tests).

👍