Skip to content

Derived datasets: Remove dummy scaling attributes from DerivedDataset class #82

@ploh

Description

@ploh

Currently, the scaling attribute is defined with

attribute :scaling,      Preset::Scaling

in DerivedDataset. But since the Preset::Scaling has attributes has_energy, has_agriculture and has_industry which are not respected when set for a DerivedDataset#scaling, this is not ideal - also, it is unnecessary, since the DerivedDataset has all the attributes of a Dataset directly, among them a lot of has_... attributes (has_energy is missing in the attributes of Dataset. Maybe we should add that? @antw @ChaelKruip).

Solution:
The Preset::Scaling class should get a newly invented superclass Atlas::Scaling without the has_.... This superclass is then used for the DerivedDataset#scaling.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions