Skip to content

Commit c4f91b4

Browse files
Ofer ShaalJosefBredereck
andauthored
Fix IE11 errors and polyfills (pattern-lab#1255)
* Fix IE11 error - SCRIPT438: Object doesn't support property or method 'forEach' * Update uikit polyfills to run pl in ie11 * Update packages/uikit-workshop/src/scripts/components/modal-styleguide.js * Update modal-styleguide.js Co-authored-by: Ofer Shaal <ofer@3paces.com> Josef Bredreck <slime.games@outlook.de>
1 parent f9430f1 commit c4f91b4

File tree

12 files changed

+15
-302
lines changed

12 files changed

+15
-302
lines changed

packages/uikit-workshop/package.json

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -59,34 +59,22 @@
5959
"@babel/runtime": "^7.6.3",
6060
"@pattern-lab/uikit-polyfills": "^5.2.0",
6161
"@reach/visually-hidden": "^0.1.2",
62-
"@skatejs/element-preact": "^0.0.1",
63-
"@skatejs/renderer-lit-html": "^0.2.2",
64-
"@skatejs/renderer-preact": "^0.3.3",
65-
"@svgr/webpack": "^4.3.3",
66-
"@ungap/url-search-params": "^0.1.2",
67-
"@webcomponents/custom-elements": "^1.3.0",
68-
"@webcomponents/shadydom": "^1.6.1",
69-
"@webcomponents/template": "^1.4.1",
62+
"@webcomponents/custom-elements": "^1.4.2",
7063
"autoprefixer": "^9.6.5",
7164
"babel-loader": "^8.0.6",
7265
"classnames": "^2.2.6",
7366
"clean-css-loader": "^1.0.1",
7467
"clean-webpack-plugin": "0.1.19",
7568
"clipboard": "^2.0.4",
7669
"copy-webpack-plugin": "^5.0.2",
77-
"core-js": "^3.3.6",
70+
"core-js": "^3.6.5",
7871
"cosmiconfig": "^5.0.6",
7972
"critical": "^1.3.4",
8073
"critical-css-webpack-plugin": "^0.2.0",
8174
"css-loader": "^3.2.0",
8275
"deepmerge": "^2.1.1",
83-
"document-register-element": "^1.13.3",
84-
"element-closest": "2.0.2",
85-
"es6-promise": "^4.2.8",
86-
"fg-loadcss": "^2.1.0",
8776
"fg-loadjs": "^1.1.0",
8877
"fuse.js": "^3.4.5",
89-
"get-own-property-symbols": "^0.9.4",
9078
"hard-source-webpack-plugin-patch": "^0.13.3",
9179
"hogan.js": "^3.0.2",
9280
"htm": "^1.0.1",
@@ -95,13 +83,11 @@
9583
"iframe-resizer": "^3.6.5",
9684
"lit-element": "^2.2.1",
9785
"lit-html": "^1.1.2",
98-
"local-chrome": "^0.1.0",
9986
"mini-css-extract-plugin": "^0.8.0",
10087
"mousetrap": "^1.6.3",
10188
"no-emit-webpack-plugin": "^1.0.0",
10289
"node-sass": "^4.14.1",
10390
"node-sass-selector-importer": "^5.2.0",
104-
"penthouse": "^2.2.2",
10591
"postcss-loader": "^3.0.0",
10692
"preact": "8.3.1",
10793
"preact-compat": "3.18.4",
@@ -112,31 +98,25 @@
11298
"pretty": "^2.0.0",
11399
"prismjs": "^1.15.0",
114100
"pwa-helpers": "^0.9.0",
115-
"raw-loader": "^3.1.0",
116101
"react-autosuggest": "^9.4.2",
117102
"react-dom": "^16.8.6",
118103
"react-html-parser": "^2.0.2",
119104
"react-popper-tooltip": "^2.7.0",
120105
"redux": "3.7.2",
121106
"redux-thunk": "^2.3.0",
122-
"reselect": "^3.0.1",
123107
"sass-loader": "^8.0.0",
124108
"scriptjs": "^2.5.8",
125109
"scroll-js": "^2.2.0",
126110
"skatejs": "^5.2.4",
127111
"style-loader": "^1.0.0",
128112
"svg-sprite-loader": "^4.1.6",
129113
"svg-transform-loader": "^2.0.8",
130-
"svgo": "^1.3.0",
131114
"svgo-loader": "^2.2.1",
132115
"ts-loader": "^6.2.1",
133-
"url-search-params-polyfill": "^5.0.0",
134116
"webpack": "^4.41.2",
135117
"webpack-cli": "^3.3.9",
136118
"webpack-merge": "^4.2.2",
137-
"whendefined": "^0.0.1",
138119
"wolfy87-eventemitter": "^5.2.6",
139-
"workbox-build": "^3.4.1",
140120
"yargs": "^14.2.0"
141121
},
142122
"browserslist": [

packages/uikit-workshop/src/scripts/components/modal-styleguide.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@ export const modalStyleguide = {
2222
// go through the panel toggles and add click event to the pattern extra toggle button
2323
const toggles = document.querySelectorAll('.pl-js-pattern-extra-toggle');
2424

25-
toggles.forEach(toggle => {
26-
toggle.addEventListener('click', e => {
27-
const patternPartial = toggle.getAttribute('data-patternpartial');
25+
for (let i = 0; i < toggles.length; i++) {
26+
toggles[i].addEventListener('click', e => {
27+
const patternPartial = toggles[i].getAttribute('data-patternpartial');
2828
modalStyleguide.toggle(patternPartial);
2929
});
30-
});
30+
}
3131
},
3232

3333
/**

packages/uikit-workshop/src/scripts/components/pl-nav/pl-nav.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import { store } from '../../store.js'; // redux store
99
import { BaseComponent } from '../base-component.js';
1010
import { iframeMsgDataExtraction } from '../../utils';
1111
import Mousetrap from 'mousetrap';
12-
import 'url-search-params-polyfill';
1312

1413
import { NavTitle } from './src/NavTitle';
1514
import { NavList } from './src/NavList';
@@ -34,6 +33,7 @@ class Nav extends BaseComponent {
3433

3534
handlePageClick(e) {
3635
if (
36+
e.target.closest &&
3737
e.target.closest('.pl-c-nav') === null &&
3838
e.target.closest('.pl-js-nav-trigger') === null &&
3939
e.target.closest('svg') === null &&

packages/uikit-workshop/src/scripts/lit-components/pl-viewport/pl-viewport.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
/* eslint-disable no-unused-vars, no-param-reassign */
2-
import URLSearchParams from '@ungap/url-search-params'; // URLSearchParams poly for older browsers
32
import { ifDefined } from 'lit-html/directives/if-defined';
43
import { store } from '../../store.js'; // connect to redux
54
import { updateCurrentPattern, updateCurrentUrl } from '../../actions/app.js'; // redux actions

packages/uikit-workshop/src/scripts/patternlab-pattern.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
11
import 'regenerator-runtime/runtime';
2-
if (window.NodeList && !NodeList.prototype.forEach) {
3-
NodeList.prototype.forEach = Array.prototype.forEach;
4-
}
5-
import '@pattern-lab/uikit-polyfills/platform/custom-event';
6-
import '@pattern-lab/uikit-polyfills/platform/symbol';
72
import './components/modal-styleguide';
83
import './components/pl-search/pl-search.iframe-helper';
94
import './components/pl-nav/pl-nav.iframe-helper';

packages/uikit-workshop/src/scripts/utils/polyfills/custom-event-polyfill.js

Lines changed: 0 additions & 51 deletions
This file was deleted.

packages/uikit-workshop/src/scripts/utils/polyfills/index.js

Lines changed: 0 additions & 5 deletions
This file was deleted.

packages/uikit-workshop/src/scripts/utils/polyfills/polyfill-loader.js

Lines changed: 0 additions & 71 deletions
This file was deleted.

packages/uikit-workshop/src/scripts/utils/polyfills/polyfills-shared.js

Lines changed: 0 additions & 69 deletions
This file was deleted.

packages/uikit-workshop/src/scripts/utils/polyfills/polyfills.js

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)