Skip to content

Commit 47e6cec

Browse files
authored
Merge pull request #1261 from ohksj77/handle-mifired-trigger-exception-2.4.x
Handle exceptions thrown while retrieving the misfired trigger
2 parents fe1b374 + 175941d commit 47e6cec

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

quartz/src/main/java/org/quartz/impl/jdbcjobstore/JobStoreSupport.java

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -970,16 +970,26 @@ conn, STATE_WAITING, getMisfireTime(),
970970
}
971971

972972
for (TriggerKey triggerKey: misfiredTriggers) {
973-
974-
OperableTrigger trig =
975-
retrieveTrigger(conn, triggerKey);
976973

977-
if (trig == null) {
974+
OperableTrigger trig;
975+
976+
try {
977+
trig = retrieveTrigger(conn, triggerKey);
978+
} catch (Exception e) {
979+
getLog().error("Error retrieving the misfired trigger: {}", triggerKey, e);
978980
continue;
979981
}
980982

981-
doUpdateOfMisfiredTrigger(conn, trig, false, STATE_WAITING, recovering);
983+
if (trig == null) {
984+
continue;
985+
}
982986

987+
try {
988+
doUpdateOfMisfiredTrigger(conn, trig, false, STATE_WAITING, recovering);
989+
} catch (Exception e) {
990+
getLog().error("Error updating misfired trigger: {}", trig.getKey(), e);
991+
continue;
992+
}
983993
if(trig.getNextFireTime() != null && trig.getNextFireTime().getTime() < earliestNewTime)
984994
earliestNewTime = trig.getNextFireTime().getTime();
985995
}

0 commit comments

Comments
 (0)