panache-data-rest and beanValidation with @AssertTrue and Boolean types

[akil-rails]

Is it expected that Boolean return types with @AssertTrue dont result in validation errors ?

The below does not raise a validation error

@Entity
public class BranchEntity extends PanacheEntity {
  @NotBlank
  public String name;
  public String ifsc;
  public String address;
  public String zip;

  @AssertTrue(message = "Branch must have a valid name, IFSC, address, and zip code")
  public Boolean isValid() {
    return false;
  }
}

but the below does raise a validation error (only change is boolean instead of Boolean)

@Entity
public class BranchEntity extends PanacheEntity {
  @NotBlank
  public String name;
  public String ifsc;
  public String address;
  public String zip;

  @AssertTrue(message = "Branch must have a valid name, IFSC, address, and zip code")
  public boolean isValid() {
    return false;
  }
}

The javadoc says that @AssertTrue works for both Boolean and boolean

/**
 * The annotated element must be true.
 * Supported types are {@code boolean} and {@code Boolean}.
 * <p>
 * {@code null} elements are considered valid.
 *
 * @author Emmanuel Bernard
 */

[quarkus-bot[bot]]

/cc @FroMage (panache), @loicmathieu (panache)

[FroMage]

Any BV experts here @gsmet ?

[gsmet]

Yeah, I would expect either both to work or both to not work :)

/cc @marko-bekhta any idea?

[marko-bekhta]

yes ... the big boolean is considered an object and hence it is expected that a getXXX is used for its getter, and isXXX is only applicable if the return type is a primitive boolean:

https://github.com/hibernate/hibernate-validator/blob/4b8969ca22bc6df00173994168a31f57c88249b8/engine/src/main/java/org/hibernate/validator/internal/properties/DefaultGetterPropertySelectionStrategy.java#L81-L102 ( see also the javadoc above this method)

so in other words, Hibernate Validator does not consider Boolean isValid() to be a getter method and ignores it when it comes to validating bean properties.