When using RestResponse in a REST client, is it expected behaviour for it to throw an exception for HTTP status codes ≥ 400?

[celcius112]

Hello everyone,

I've recently started using the Quarkus REST client. In my career, I’ve mostly worked with Retrofit and Feign.

From what I recall, when using a return type like Response in Retrofit or Feign, an exception isn't thrown for 4xx or 5xx responses — you just get the response object and handle the status accordingly.

However, I was surprised to find that this doesn’t seem to be the case with the Quarkus REST client. When calling a method that returns a RestResponse or Response, an exception is thrown on HTTP errors.

Is this the expected behaviour, or could I be missing something? Personally, I find working directly with a Response object much cleaner than handling exceptions.

Thanks!

[quarkus-bot[bot]]

/cc @cescoffier (rest-client), @geoand (rest-client)

[celcius112]

As an example, let's say I have this client:

@Path("/extensions")
@RegisterRestClient
public interface ExtensionsService {

    @DELETE
    @Path("/{id}")
    RestResponse<Void> deleteById(@PathParam("id") String id);
}

and I want to handle this call this way:

        RestResponse<Void> response = extensionService.deleteById(id);
        if (response.getStatus() != 404 && response.getStatus() >= 400) {
            throw new RuntimeException("There is an exception !");
        }

This is not possible because deleteById will throw a ClientWebApplicationException on error.

[DevEnol]

CMIIW, I think it is because the default behavior in the Microprofile Rest Client to handle with response mapper. However you can disable by using this configuration in application.properties.

microprofile.rest.client.disable.default.mapper = true

[celcius112]

interesting, thanks for that ! it's just a shame that it would also apply to methods not returning a Response

[geoand]

Totally agreed

[DevEnol]

@celcius112 I trust that you aware, when manually handling the response, you need to close the resource via try with resource pattern:

try(RestResponse<Void> response = extensionService.deleteById(id)) {

        if (response.getStatus() != 404 && response.getStatus() >= 400) {
            throw new RuntimeException("There is an exception !");
        }
}

While using the default response mapper, I think would close the resource automatically.

[celcius112]

@DevEnol of course. it just was not relevant to the problem at hand. I did not want to add too much information

[geoand]

It does seem that this is the standard behavior - which I totally agree is not a great default...