Java 17 to 21 Custom Config Source Not Loaded in CommonForkJoinPool

[brianwyka]

When upgrading the java version from 17 to 21 in some cases, the constructor annotated with @Inject and having parameters annotated with @ConfigProperty are not properly getting injected. This is the case for raw value, and also Provider instances as well. Not sure if this is a Microprofile COnfig issue, but I can't seem to resolve the problem.

Example code which does not have any values injected and throws exceptions when the config not found.

• The int and double values come as value 0 in this case
• The Provider values throw the following exception:

java.util.NoSuchElementException: SRCFG00014: The config property bucket is required but it could not be found in any config source

@ApplicationScoped
public class S3Service {

    @Inject
    public S3Service(
        final S3Client s3Client,
        @ConfigProperty(name = "bucket") final Provider<String> bucket,
        @ConfigProperty(name = "bucket.encryption") final Provider<String> bucketEncryption,
        @ConfigProperty(name = "max.concurrency") final int maxConcurrency,
        @ConfigProperty(name = "min.part.size.in.mb") final int minPartSizeInMB,
        @ConfigProperty(name = "target.throughput") final double targetThroughputInGBPS) {
        this(s3Client,
            S3TransferManager.builder()
                .s3Client(S3AsyncClient.crtBuilder()
                    .targetThroughputInGbps(targetThroughputInGBPS)
                    .minimumPartSizeInBytes(minPartSizeInMB * MB)
                    .maxConcurrency(maxConcurrency)
                    .build())
                .build(),
            bucket, bucketEncryption);
    }

   ...

}

[quarkus-bot[bot]]

/cc @radcortez (config)

[brianwyka]

I think I have some more details. Let me expand the example above.

[brianwyka]

I don't have a reproducer yet, but I was able to at least verify a custom config source that I am using was not available within the ConfigProvider instance being used... Still investigating why.

[brianwyka]

It looks like it was due to classloader behavior change. It's an issue with my custom ConfigSource, but when the code was running inside the CommonForkJoinPool,

in Java 17 it was the io.quarkus.bootstrap.runner.RunnerClassLoader,
In java 21 it is: jdk.internal.loader.ClassLoaders$AppClassLoader

[brianwyka]

@radcortez , I was able to "resolve" the issue by setting the following Java system property:

-Djava.util.concurrent.ForkJoinPool.common.threadFactory=io.quarkus.bootstrap.forkjoin.QuarkusForkJoinWorkerThreadFactory

Is this the desired workaround or fix or is there something more elegant?

[radcortez]

Usually, Quarkus already sets that up for you. How are you running your Quarkus application?

[brianwyka]

It's a typical setup, nothing customized there. The only thing that I think may have contributed to this is the custom config source. I identified code I wrote which skips loading configurations based on the classloader used. I did this because the config source is in a library and it is not built in a "quarkus extension" style. Here is the code:

    /**
     * Determine if we should skip loading the config source.  This is useful to prevent initializing configurations during build time,
     * or with any other classloading phase that it is not required in.
     *
     * See Quarkus documentation for more details:
     * <a href="https://quarkus.io/guides/class-loading-reference">Classloading Reference</a>
     *
     * @return true if loading should be skipped, false otherwise
     */
    private static boolean shouldSkipLoading() {
        if ("true".equals(System.getProperty("build.unit.test"))) {
            return false; // This covers non Quarkus application / unit tests that rely on Microprofile Config
        }
        final var classLoader = Thread.currentThread().getContextClassLoader().toString();
        return !classLoader.contains("io.quarkus.bootstrap.runner.RunnerClassLoader") // Classloader in Quarkus PROD mode
            && !classLoader.contains("QuarkusClassLoader:Quarkus Runtime ClassLoader"); // Classloader in Quarkus DEV/TEST mode
    }

[radcortez]

You may want to check SmallRyeConfigBuilderCustomizer and ConfigSourceFactory:

• https://smallrye.io/smallrye-config/3.12.3/config/customizer/
• https://smallrye.io/smallrye-config/3.12.3/config-sources/factories/

With that you can play around with the builder or the factory to register sources selectively.

[brianwyka]

The code I shared above is in a factory class, and the shouldSkipLoading() method is called from the

public Iterable<ConfigSource> getConfigSources(final ConfigSourceContext context) {

method.