Java Money (JSR 354) and Quarkus

[andlinger]

We use the Java Money library in most of our projects. The library initializes its components with SPIs which are not really compatible with Quarkus. For this we have implemented our own ServiceProvider which initializes the respective components statically. I would like to implement a Quarkus extension that does this neatly.

Maybe I could implement an own service provider which registers the components via CDI.
Are there any ideas how I can implement this best? Is there already a Quarkus extension that does something similar?

[geoand]

What problems did you encounter with using the SPIs in Quarkus?

[andlinger]

Using the Java Money library example, the individual services are not registered in the service provider. In native mode, this results in the following exceptions, for example:

Caused by: javax.money.MonetaryException: No MonetaryConversionsSingletonSpi loaded, query functionality is not available.
        at javax.money.convert.MonetaryConversions.lambda$getMonetaryConversionsSpi$0(MonetaryConversions.java:66)
        at java.base@17.0.5/java.util.Optional.orElseThrow(Optional.java:403)
        at javax.money.convert.MonetaryConversions.getMonetaryConversionsSpi(MonetaryConversions.java:66)
        at javax.money.convert.MonetaryConversions.getExchangeRateProvider(MonetaryConversions.java:176)
        at package.services.MoneyConvertService.convert(MoneyConvertService.java:12)
        at package.services.MoneyConvertService_ClientProxy.convert(Unknown Source)
        at package.resources.TestResource.getUnpaid(TestResource.java:32)
        at package.resources.TestResource_Subclass.getUnpaid$$superforward1(Unknown Source)
        at package.resources.TestResource_Subclass$$function$$1.apply(Unknown Source)
        at io.quarkus.arc.impl.AroundInvokeInvocationContext.proceed(AroundInvokeInvocationContext.java:54)
        at io.quarkus.security.runtime.interceptor.SecurityHandler.handle(SecurityHandler.java:47)
        at io.quarkus.security.runtime.interceptor.PermitAllInterceptor.intercept(PermitAllInterceptor.java:23)
        at io.quarkus.security.runtime.interceptor.PermitAllInterceptor_Bean.intercept(Unknown Source)
        at io.quarkus.arc.impl.InterceptorInvocation.invoke(InterceptorInvocation.java:42)
        at io.quarkus.arc.impl.AroundInvokeInvocationContext.perform(AroundInvokeInvocationContext.java:41)
        at io.quarkus.arc.impl.InvocationContexts.performAroundInvoke(InvocationContexts.java:33)
        at package.resources.TestResource_Subclass.getUnpaid(Unknown Source)
        at package.resources.TestResource_ClientProxy.getUnpaid(Unknown Source)
        at java.base@17.0.5/java.lang.reflect.Method.invoke(Method.java:568)
        at org.jboss.resteasy.core.MethodInjectorImpl.invoke(MethodInjectorImpl.java:170)
        at org.jboss.resteasy.core.MethodInjectorImpl.invoke(MethodInjectorImpl.java:130)
        at org.jboss.resteasy.core.ResourceMethodInvoker.internalInvokeOnTarget(ResourceMethodInvoker.java:660)
        at org.jboss.resteasy.core.ResourceMethodInvoker.invokeOnTargetAfterFilter(ResourceMethodInvoker.java:524)
        at org.jboss.resteasy.core.ResourceMethodInvoker.lambda$invokeOnTarget$2(ResourceMethodInvoker.java:474)
        at org.jboss.resteasy.core.interception.jaxrs.PreMatchContainerRequestContext.filter(PreMatchContainerRequestContext.java:364)
        at org.jboss.resteasy.core.ResourceMethodInvoker.invokeOnTarget(ResourceMethodInvoker.java:476)
        at org.jboss.resteasy.core.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:434)
        at org.jboss.resteasy.core.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:408)
        at org.jboss.resteasy.core.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:69)
        at org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:492)

[geoand]

Do you have small sample project I can try? I want to debug and see why this is happening

[andlinger]

I've created a small reproducer: https://github.com/andlinger/quarkus-reproducer/tree/quarkus-discussion-30466
A request to /product works in JVM mode but not in Native mode

[geoand]

Thanks. I'll have a look this week

[geoand]

I looked into this real quickly and I agree there should be an extension.

For starters, it likely simply needs to do something like:

    @BuildStep
    public void spiRegistration(BuildProducer<ServiceProviderBuildItem> producer) {
        producer.produce(ServiceProviderBuildItem.allProvidersFromClassPath(MonetaryConversionsSingletonSpi.class.getName()));
        producer.produce(ServiceProviderBuildItem.allProvidersFromClassPath(MonetaryAmountFactoryProviderSpi.class.getName()));
        // register all other SPI classes defined in moneta
    }

[DSkoufis]

Not entirely related to the original question since we are using Quarkus 3, but we also have an issue with JavaMoney in our project.

I created a reproducer if it's of any help and started off a thread in SO too before I was pointed to this direction.
JVM build works fine but when trying to build a native executable we get an error. Apparently moneta still uses the javax package whereas the quarkus-core is on EE9/10 with the jakarta rename.

I just got started with GraalVM and native image build with Quarkus, is there a way to actually work around the issue or the only solution is to wait for JavaMoney to release a new version?

Error:

Caused by: com.oracle.graal.pointsto.constraints.UnresolvedElementException: Discovered unresolved type during parsing: javax.annotation.Priority. This error is reported at image build time because class org.javamoney.moneta.spi.PriorityAwareServiceProvider is registered for linking at image build time by command line

[geoand]

You seem to be looking for something like #33145.
We don't have that, although you could probably manually setup the eclipse transformer as a maven plugin.

[gsmet]

Another option could be to develop a small javax.money extension and use a trick similar to https://github.com/quarkusio/quarkus/blob/main/extensions/quartz/deployment/src/main/java/io/quarkus/quartz/deployment/JakartaEnablement.java .

[geoand]

There might be more brute force ways to fix it, but I'll have to see next week

[geoand]

What @gsmet proposes is probably the best way forward

[DSkoufis]

That's brilliant! The transformer worked as expected. I've also pushed my changes for future reference: ref
Thanks so much for the help both!

[geoand]

💪🏼

[andlinger]

I have now released a first version of the extension which takes both discussed topics into account. On the one hand the service providers are registered and on the other hand the dependency is transformed with the Eclipse Transformer.

[hantsy]

Java Money has released the Jakarta EE integration version, no need transforming the Jakarta EE namespace.

https://github.com/JavaMoney/jakarta-money

[ChMThiel]

jakarta-money is not released...

[andlinger]

The library you mentioned uses the org.javamoney.moneta:moneta-core library as a dependency and extends it with useful features. Nevertheless, the library still relies on javax (in this case, for example, javax.inject.Priority)