Merge pull request #3413 from quadratichq/fix-column-row-selection

Fix column row selection

Author: AyushAgrawal-A2

Cargo.toml

@@ -15,7 +15,7 @@ edition = "2024"
 description = "Infinite data grid with Python, JavaScript, and SQL built-in"
 repository = "https://github.com/quadratichq/quadratic"
 license-file = "LICENSE"
-version = "0.17.1"
+version = "0.17.2"
 
 
 [profile.release]

VERSION

@@ -1 +1 @@
-0.17.1
+0.17.2

package.json

@@ -1,6 +1,6 @@
 {
   "name": "quadratic",
-  "version": "0.17.1",
+  "version": "0.17.2",
   "author": {
     "name": "David Kircos",
     "email": "david@quadratichq.com",

quadratic-api/package.json

@@ -1,6 +1,6 @@
 {
   "name": "quadratic-api",
-  "version": "0.17.1",
+  "version": "0.17.2",
   "description": "",
   "main": "index.js",
   "scripts": {

quadratic-client/package.json

@@ -1,6 +1,6 @@
 {
   "name": "quadratic-client",
-  "version": "0.17.1",
+  "version": "0.17.2",
   "author": {
     "name": "David Kircos",
     "email": "david@quadratichq.com",

quadratic-client/public/version.json

@@ -1,3 +1,3 @@
 {
-  "version": "0.17.1"
+  "version": "0.17.2"
 }

quadratic-client/src/app/gridGL/interaction/pointer/PointerHeading.ts

@@ -166,28 +166,28 @@ export class PointerHeading {
           }
         }, DOUBLE_CLICK_TIME);
       }
+    }
 
-      // Selects multiple columns or rows. If ctrl/meta is pressed w/o shift,
-      // then it add or removes the clicked column or row. If shift is pressed,
-      // then it selects all columns or rows between the last clicked column or
-      // row and the current one.
-      const bounds = pixiApp.viewport.getVisibleBounds();
-      const headingSize = pixiApp.headings.headingSize;
-      if (intersects.column !== null) {
-        const top = sheets.sheet.getRowFromScreen(bounds.top + headingSize.height);
-        cursor.selectColumn(intersects.column, e.ctrlKey || e.metaKey, e.shiftKey, isRightClick, top);
-      } else if (intersects.row !== null) {
-        const left = sheets.sheet.getColumnFromScreen(bounds.left);
-        cursor.selectRow(intersects.row, e.ctrlKey || e.metaKey, e.shiftKey, isRightClick, left);
-      }
-      if (isRightClick) {
-        events.emit('contextMenu', {
-          world,
-          column: intersects.column ?? undefined,
-          row: intersects.row ?? undefined,
-          type: ContextMenuType.Grid,
-        });
-      }
+    // Selects multiple columns or rows. If ctrl/meta is pressed w/o shift,
+    // then it add or removes the clicked column or row. If shift is pressed,
+    // then it selects all columns or rows between the last clicked column or
+    // row and the current one.
+    const bounds = pixiApp.viewport.getVisibleBounds();
+    const headingSize = pixiApp.headings.headingSize;
+    if (intersects.column !== null) {
+      const top = sheets.sheet.getRowFromScreen(bounds.top + headingSize.height);
+      cursor.selectColumn(intersects.column, e.ctrlKey || e.metaKey, e.shiftKey, isRightClick, top);
+    } else if (intersects.row !== null) {
+      const left = sheets.sheet.getColumnFromScreen(bounds.left);
+      cursor.selectRow(intersects.row, e.ctrlKey || e.metaKey, e.shiftKey, isRightClick, left);
+    }
+    if (isRightClick) {
+      events.emit('contextMenu', {
+        world,
+        column: intersects.column ?? undefined,
+        row: intersects.row ?? undefined,
+        type: ContextMenuType.Grid,
+      });
     }
 
     return true;

quadratic-connection/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "quadratic-connection"
-version = "0.17.1"
+version = "0.17.2"
 edition = "2024"
 authors = ["David DiMaria <david.dimaria@quadratichq.com>"]
 

quadratic-core/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "quadratic-core"
-version = "0.17.1"
+version = "0.17.2"
 authors = ["Andrew Farkas <andrew.farkas@quadratic.to>"]
 edition = "2024"
 description = "Infinite data grid with Python, JavaScript, and SQL built-in"

quadratic-files/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "quadratic-files"
-version = "0.17.1"
+version = "0.17.2"
 edition = "2024"
 authors = ["David DiMaria <david.dimaria@quadratichq.com>"]