Merge pull request #2834 from quadratichq/fix-data-table-index-issu-main

davidkircos · web-flow · commit 18378dc24cfa · 2025-04-28T20:48:03.000-06:00
Hotfix index out of bounds issue
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-0.7.0
+0.7.1
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "quadratic",
-  "version": "0.7.0",
+  "version": "0.7.1",
   "author": {
     "name": "David Kircos",
     "email": "david@quadratichq.com",
diff --git a/quadratic-api/package.json b/quadratic-api/package.json
@@ -1,6 +1,6 @@
 {
   "name": "quadratic-api",
-  "version": "0.7.0",
+  "version": "0.7.1",
   "description": "",
   "main": "index.js",
   "scripts": {
diff --git a/quadratic-client/package.json b/quadratic-client/package.json
@@ -1,6 +1,6 @@
 {
   "name": "quadratic-client",
-  "version": "0.7.0",
+  "version": "0.7.1",
   "author": {
     "name": "David Kircos",
     "email": "david@quadratichq.com",
diff --git a/quadratic-client/public/version.json b/quadratic-client/public/version.json
@@ -1 +1 @@
-{"version":"0.7.0"}
+{ "version": "0.7.1" }
diff --git a/quadratic-client/src/router.tsx b/quadratic-client/src/router.tsx
@@ -16,6 +16,7 @@ export const router = createBrowserRouter(
         loader={RootRoute.loader}
         Component={RootRoute.Component}
         ErrorBoundary={RootRoute.ErrorBoundary}
+        HydrateFallback={EmptyComponent}
       >
         {/**
          * ----------------------------------------------------------------
@@ -101,9 +102,20 @@ export const router = createBrowserRouter(
         </Route>
         <Route path="*" Component={Page404.Component} />
       </Route>
-      <Route path={ROUTES.LOGIN} loader={Login.loader} />
-      <Route path={ROUTES.LOGIN_RESULT} loader={LoginResult.loader} />
-      <Route path={ROUTES.LOGOUT} loader={Logout.loader} action={Logout.action} />
+      <Route path={ROUTES.LOGIN} loader={Login.loader} Component={EmptyComponent} HydrateFallback={EmptyComponent} />
+      <Route
+        path={ROUTES.LOGIN_RESULT}
+        loader={LoginResult.loader}
+        Component={EmptyComponent}
+        HydrateFallback={EmptyComponent}
+      />
+      <Route
+        path={ROUTES.LOGOUT}
+        loader={Logout.loader}
+        action={Logout.action}
+        Component={EmptyComponent}
+        HydrateFallback={EmptyComponent}
+      />
     </>
   ),
   {}
@@ -118,3 +130,14 @@ function dontRevalidateDialogs({ currentUrl, nextUrl }: ShouldRevalidateFunction
   }
   return true;
 }
+
+// Because our `index.html` starts with a loading state, which we remove when
+// the app loads, we're fine rendering an empty component in various places.
+// This is an explicit way to say what's implicitly happening.
+// Otherwise, if we don't include thise, we get a bunch of console.warn()
+// messages like "No HydrateFallback provided" or
+// "Matched leaf route at location ... does not have an element..." which
+// blog up sentry.
+function EmptyComponent() {
+  return null;
+}
diff --git a/quadratic-connection/Cargo.lock b/quadratic-connection/Cargo.lock
diff --git a/quadratic-connection/Cargo.toml b/quadratic-connection/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "quadratic-connection"
-version = "0.7.0"
+version = "0.7.1"
 edition = "2024"
 authors = ["David DiMaria <david.dimaria@quadratichq.com>"]
 
diff --git a/quadratic-core/Cargo.lock b/quadratic-core/Cargo.lock
diff --git a/quadratic-core/Cargo.toml b/quadratic-core/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "quadratic-core"
-version = "0.7.0"
+version = "0.7.1"
 authors = ["Andrew Farkas <andrew.farkas@quadratic.to>"]
 edition = "2024"
 description = "Infinite data grid with Python, JavaScript, and SQL built-in"
diff --git a/quadratic-core/src/controller/execution/run_code/mod.rs b/quadratic-core/src/controller/execution/run_code/mod.rs
@@ -128,7 +128,8 @@ impl GridController {
             let index = index.min(sheet.data_tables.len());
             sheet
                 .data_tables
-                .shift_insert(index, pos, new_data_table.to_owned())
+                .insert_before(index, pos, new_data_table.to_owned())
+                .1
         } else {
             sheet.data_tables.shift_remove(&pos)
         };
diff --git a/quadratic-files/Cargo.lock b/quadratic-files/Cargo.lock
diff --git a/quadratic-files/Cargo.toml b/quadratic-files/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "quadratic-files"
-version = "0.7.0"
+version = "0.7.1"
 edition = "2024"
 authors = ["David DiMaria <david.dimaria@quadratichq.com>"]
 
diff --git a/quadratic-multiplayer/Cargo.lock b/quadratic-multiplayer/Cargo.lock
diff --git a/quadratic-multiplayer/Cargo.toml b/quadratic-multiplayer/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "quadratic-multiplayer"
-version = "0.7.0"
+version = "0.7.1"
 edition = "2024"
 authors = ["David DiMaria <david.dimaria@quadratichq.com>"]
 
diff --git a/quadratic-rust-shared/Cargo.lock b/quadratic-rust-shared/Cargo.lock
diff --git a/quadratic-rust-shared/Cargo.toml b/quadratic-rust-shared/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "quadratic-rust-shared"
-version = "0.7.0"
+version = "0.7.1"
 edition = "2024"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
diff --git a/quadratic-shared/package.json b/quadratic-shared/package.json
@@ -1,6 +1,6 @@
 {
   "name": "quadratic-shared",
-  "version": "0.7.0",
+  "version": "0.7.1",
   "description": "Code shared between quadratic-api and quadratic-client (each app has to compile this code itself)",
   "main": "index.js",
   "scripts": {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "quadratic",`
`3`		`- "version": "0.7.0",`
	`3`	`+ "version": "0.7.1",`
`4`	`4`	`"author": {`
`5`	`5`	`"name": "David Kircos",`
`6`	`6`	`"email": "david@quadratichq.com",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "quadratic-api",`
`3`		`- "version": "0.7.0",`
	`3`	`+ "version": "0.7.1",`
`4`	`4`	`"description": "",`
`5`	`5`	`"main": "index.js",`
`6`	`6`	`"scripts": {`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "quadratic-client",`
`3`		`- "version": "0.7.0",`
	`3`	`+ "version": "0.7.1",`
`4`	`4`	`"author": {`
`5`	`5`	`"name": "David Kircos",`
`6`	`6`	`"email": "david@quadratichq.com",`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{"version":"0.7.0"}`
	`1`	`+{ "version": "0.7.1" }`