Skip to content

Optimization suggestion for org.slf4j.helpers.MessageFormatter.arrayFormat(String, Object[], Throwable) #435

@dukeware

Description

@dukeware

In order to reduce unnecessary expenses:

deeplyAppendParameter(sbuf, argArray[L], new HashMap<>());

should be:

deeplyAppendParameter(sbuf, argArray[L], null);

Correspondingly, in org.slf4j.helpers.MessageFormatter.deeplyAppendParameter(StringBuilder, Object, Map<Object[], Object>)

objectArrayAppend(sbuf, (Object[]) o, seenMap);

change to:

objectArrayAppend(sbuf, (Object[]) o, seenMap != null ? seenMap : new HashMap<>());

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions