Skip to content

Replace xm.mark_step with torch_xla.sync() in examples and tests #8862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tengyifei opened this issue Mar 19, 2025 · 1 comment · May be fixed by #9070
Open

Replace xm.mark_step with torch_xla.sync() in examples and tests #8862

tengyifei opened this issue Mar 19, 2025 · 1 comment · May be fixed by #9070
Labels
documentation enhancement New feature or request usability Bugs/features related to improving the usability of PyTorch/XLA

Comments

@tengyifei
Copy link
Collaborator

torch_xla.sync() is easier to spell than xm.mark_step(). We should at least replace mark_step in all public examples.
@tengyifei tengyifei added the usability Bugs/features related to improving the usability of PyTorch/XLA label Mar 19, 2025
@ysiraichi ysiraichi added enhancement New feature or request documentation labels Mar 20, 2025
@miladm
Copy link
Collaborator

miladm commented Mar 29, 2025

@tengyifei instead of one off bugs, wdyt we prepare a "deprecation" github RFC with a running list of ops we wish to drop / replace with better alternatives.

It'd be great to publicize and reference this RFC in our 2.7 release note for wider visibility.

cc @yaoshiang @zpcore

@ghpvnist ghpvnist linked a pull request May 1, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation enhancement New feature or request usability Bugs/features related to improving the usability of PyTorch/XLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace xm.mark_step with torch_xla.sync() wherever possible ghpvnist/xla
3 participants
@miladm @tengyifei @ysiraichi