File tree Expand file tree Collapse file tree 1 file changed +3
-1
lines changed
torchtitan/experiments/simple_fsdp Expand file tree Collapse file tree 1 file changed +3
-1
lines changed Original file line number Diff line number Diff line change @@ -128,9 +128,11 @@ def _register_parametrization(
128
128
module : nn .Module , param_names : List [str ], parametrization : nn .Module
129
129
):
130
130
"""
131
- it works with state_dict without incurring parametrization calls because
131
+ It works with state_dict without incurring parametrization calls because
132
132
state_dict accesses parameters directly from self._parameters, not from getters
133
133
https://github.com/pytorch/pytorch/blob/main/torch/nn/modules/module.py#L2141
134
+ TODO: In checkpoint saving/loading, avoid parametrization calls when calling
135
+ get_model_state_dict func in torchtitan's torchtitan/components/checkpoint.py.
134
136
"""
135
137
param_name_to_property = {
136
138
param_name : property (lambda self : parametrization (self ._parameters [param_name ]))
You can’t perform that action at this time.
0 commit comments