Skip to content

Commit fdee633

Browse files
author
Vincent Moens
authored
[BugFix] Fix gym benchmark (#1619)
1 parent 805918c commit fdee633

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

benchmarks/ecosystem/gym_env_throughput.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,14 @@
3030

3131
if __name__ == "__main__":
3232
for envname in [
33-
"HalfCheetah-v4",
3433
"CartPole-v1",
34+
"HalfCheetah-v4",
3535
"myoHandReachRandom-v0",
3636
"ALE/Breakout-v5",
37-
"CartPole-v1",
3837
]:
3938
# the number of collectors won't affect the resources, just impacts how the envs are split in sub-sub-processes
40-
for num_workers, num_collectors in zip((8, 16, 32, 64), (2, 4, 8, 8)):
41-
with open(
42-
f"atari_{envname}_{num_workers}.txt".replace("/", "-"), "w+"
43-
) as log:
39+
for num_workers, num_collectors in zip((32, 64, 8, 16), (8, 8, 2, 4)):
40+
with open(f"{envname}_{num_workers}.txt".replace("/", "-"), "w+") as log:
4441
if "myo" in envname:
4542
gym_backend = "gym"
4643
else:
@@ -219,7 +216,7 @@ def make_env(
219216

220217
penv = EnvCreator(
221218
lambda num_workers=num_workers // num_collectors: make_env(
222-
num_workers
219+
num_workers=num_workers
223220
)
224221
)
225222
collector = MultiaSyncDataCollector(
@@ -306,7 +303,7 @@ def make_env(
306303

307304
penv = EnvCreator(
308305
lambda num_workers=num_workers // num_collectors: make_env(
309-
num_workers
306+
num_workers=num_workers
310307
)
311308
)
312309
collector = MultiSyncDataCollector(

0 commit comments

Comments
 (0)