Skip to content

Commit aad6684

Browse files
authored
[CI] Fix windows CI (#1128)
1 parent 09f71b1 commit aad6684

File tree

2 files changed

+38
-23
lines changed

2 files changed

+38
-23
lines changed

.circleci/config.yml

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1055,19 +1055,19 @@ jobs:
10551055
name: Generate cache key
10561056
# This will refresh cache on Sundays, nightly build should generate new cache.
10571057
command: echo "$(date +"%Y-%U")" > .circleci-weekly
1058-
- restore_cache:
1059-
keys:
1060-
- env-v2-windows-{{ arch }}-py<< parameters.python_version >>-{{ checksum ".circleci/unittest/windows_optdepts/scripts/environment.yml" }}-{{ checksum ".circleci-weekly" }}
1058+
# - restore_cache:
1059+
# keys:
1060+
# - env-v2-windows-{{ arch }}-py<< parameters.python_version >>-{{ checksum ".circleci/unittest/windows_optdepts/scripts/environment.yml" }}-{{ checksum ".circleci-weekly" }}
10611061

10621062
- run:
10631063
name: Setup
10641064
command: .circleci/unittest/windows_optdepts/scripts/setup_env.sh
1065-
- save_cache:
1066-
key: env-v2-windows-{{ arch }}-py<< parameters.python_version >>-{{ checksum ".circleci/unittest/windows_optdepts/scripts/environment.yml" }}-{{ checksum ".circleci-weekly" }}
1067-
1068-
paths:
1069-
- conda
1070-
- env
1065+
# - save_cache:
1066+
# key: env-v2-windows-{{ arch }}-py<< parameters.python_version >>-{{ checksum ".circleci/unittest/windows_optdepts/scripts/environment.yml" }}-{{ checksum ".circleci-weekly" }}
1067+
#
1068+
# paths:
1069+
# - conda
1070+
# - env
10711071
- run:
10721072
name: Install torchrl
10731073
command: .circleci/unittest/windows_optdepts/scripts/install.sh
@@ -1094,19 +1094,19 @@ jobs:
10941094
name: Generate cache key
10951095
# This will refresh cache on Sundays, nightly build should generate new cache.
10961096
command: echo "$(date +"%Y-%U")" > .circleci-weekly
1097-
- restore_cache:
1098-
keys:
1099-
- env-v1-windows-{{ arch }}-py<< parameters.python_version >>-{{ checksum ".circleci/unittest/windows_optdepts/scripts/environment.yml" }}-{{ checksum ".circleci-weekly" }}
1097+
# - restore_cache:
1098+
# keys:
1099+
# - env-v1-windows-{{ arch }}-py<< parameters.python_version >>-{{ checksum ".circleci/unittest/windows_optdepts/scripts/environment.yml" }}-{{ checksum ".circleci-weekly" }}
11001100

11011101
- run:
11021102
name: Setup
11031103
command: .circleci/unittest/windows_optdepts/scripts/setup_env.sh
1104-
- save_cache:
1105-
key: env-v1-windows-{{ arch }}-py<< parameters.python_version >>-{{ checksum ".circleci/unittest/windows_optdepts/scripts/environment.yml" }}-{{ checksum ".circleci-weekly" }}
1106-
1107-
paths:
1108-
- conda
1109-
- env
1104+
# - save_cache:
1105+
# key: env-v1-windows-{{ arch }}-py<< parameters.python_version >>-{{ checksum ".circleci/unittest/windows_optdepts/scripts/environment.yml" }}-{{ checksum ".circleci-weekly" }}
1106+
#
1107+
# paths:
1108+
# - conda
1109+
# - env
11101110
- run:
11111111
name: Install CUDA
11121112
command: packaging/windows/internal/cuda_install.bat
@@ -1200,9 +1200,9 @@ workflows:
12001200

12011201
- unittest_windows_optdepts_cpu:
12021202
cu_version: cpu
1203-
name: unittest_windows_optdepts_cpu_py3.8
1204-
python_version: '3.8'
1203+
name: unittest_windows_optdepts_cpu_py3.9
1204+
python_version: '3.9'
12051205
- unittest_windows_optdepts_gpu:
12061206
cu_version: cu116
1207-
name: unittest_windows_optdepts_gpu_py3.8
1208-
python_version: '3.8'
1207+
name: unittest_windows_optdepts_gpu_py3.9
1208+
python_version: '3.9'

.circleci/unittest/windows_optdepts/scripts/install.sh

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,22 @@ fi
5959
# install tensordict
6060
pip3 install git+https://github.com/pytorch-labs/tensordict
6161

62+
# smoke test
63+
python -c """
64+
from tensordict import TensorDict
65+
print('successfully imported tensordict')
66+
"""
67+
6268
source "$this_dir/set_cuda_envs.sh"
6369

6470
printf "* Installing torchrl\n"
65-
pip3 install -e .
71+
python setup.py develop
72+
73+
whatsinside=$(ls -rtlh ./torchrl)
74+
echo $whatsinside
75+
76+
# smoke test
77+
python -c """
78+
from torchrl.data import ReplayBuffer
79+
print('successfully imported torchrl')
80+
"""

0 commit comments

Comments
 (0)